Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirstVersionsofDiTauHLTPaths_forPhase2 [13_1_X] #42649

Merged

Conversation

hsert
Copy link
Contributor

@hsert hsert commented Aug 23, 2023

First versions of ditau HLT paths for Phase2 with charged isolation and DeepTau Isolation (using Run2 training) are added.

Detailed description of PR is given in the original PR: #42562

We would like that PR will be backported to CMSSW_13_1_X release, since the studies for Phase 2 HLT is ongoing in that release.

I used CMSSW_13_1_X_2023-08-18-1100 release for testing. After initialization, the merged branch is rebased with
git cms-rebase-topic --old-base CMSSW_13_3_X_2023-08-15-1100 hsert:tauHLTPhase2_dev
and run the following runMatrix test, and there was no failed run.
runTheMatrix.py -l limited -i all --ibeos

…nd DeepTau Isolation (using Run2 training) are added.
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 23, 2023

A new Pull Request was created by @hsert (HaleSert) for CMSSW_13_1_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato, @SohamBhattacharya, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

backport of #42562

@missirol
Copy link
Contributor

please test

@missirol
Copy link
Contributor

@hsert , while not strictly needed for HLT Phase-2 studies, I would prefer to also have a backport to 13_2_X as done for other recent HLT Phase-2 PRs. Can you please open a backport to 13_2 ? Thanks.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f85b5f/34456/summary.html
COMMIT: e2c2781
CMSSW: CMSSW_13_1_X_2023-08-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42649/34456/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 17 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 37 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3186945
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3186917
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@hsert hsert changed the title Backport of PR #42562 to CMSSW_13_1_X: diTauHLTPaths_forPhase2 FirstVersionsofDiTauHLTPaths_forPhase2 [13_1_X] Aug 24, 2023
@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants