L1T Phase-2 Correlator Layer 1 updates for Multiboard tests

[gpetruc]

PR description:

This PR updates the Level-1 Trigger Phase-2 Correlator Layer 1 code:

• the hgcal cluster word unpacker emulator can now be configured to unpack also the extra shower shape variables or not, to match what the firmware does inside vs outside the tracker coverage
  • In cms-l1t-offline, this in cms-l1t-offline@382fffe from TkElectron v2 algo: Composite ID cms-l1t-offline/cmssw#1096 but that commit was lost when porting to cmssw-master with Phase-2 L1T e/g: new Composite Electron ID #41290
• the forward hgcal region is now emulated accurately (physics performance should be unchanged since occupancies are well below the threshold at which truncations happen)
• emulation of the correlator at tmux18 is now possible in CMSSW
• the correlator pattern file writers are updated to run on the newer samples, to use a cabling map that reflects the current firmware, and to support also the tmux18 option

Corresponds to cms-l1t-offline cms-l1t-offline#1157

I'll soon update both PRs with the fillDescriptions for the Level-1 Trigger Phase-2 Correlator Layer 1 code which I'm currently validating, but I would like to have jenkins run first a set of tests without those changes, and give a chance to the reviewers to see the code before those changes if they want (the fillDescriptions part will be a lot of code changes that shouldn't make any difference at all in the results, so I'd rather factor them out)

PR validation:

Tested in CMSSW_13_3_X_2023-08-21-2300 on el8, with:

• the usual scram b code-format && scram b code-checks && scram b check-headers && scram b runtests
• matrix workflow 23234.0_TTbar_14TeV+2026D94
• running make_l1ct_binaryFiles_cfg.py under L1Trigger/Phase2L1ParticleFlow/test

@cerminar

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42643/36698

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for master.

It involves the following packages:

• L1Trigger/Phase2L1ParticleFlow (upgrade, l1)

@epalencia, @AdrianoDee, @srimanob, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[gpetruc]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01aa5f/34451/summary.html
COMMIT: d536c12
CMSSW: CMSSW_13_3_X_2023-08-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42643/34451/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 23 lines from the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3153095
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153067
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

@gpetruc Am I waiting for fillDescriptions updates on this? Otherwise this all looks good to me.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01aa5f/34487/summary.html
COMMIT: 308ac75
CMSSW: CMSSW_13_3_X_2023-08-24-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42643/34487/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 9 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3153095
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153070
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[gpetruc]

Hello @AdrianoDee @srimanob can you review this PR as well?

L1 has already signed it off last week.

Thanks,

Giovanni

[srimanob]

@cmsbuild please test

Retrigger the test after 2 weeks

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01aa5f/34676/summary.html
COMMIT: 308ac75
CMSSW: CMSSW_13_3_X_2023-09-10-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42643/34676/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 7 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3153414
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153389
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1