Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_2_X (1/N) #42611

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Aug 19, 2023

backport of #42610

PR description:

Development of HLT menus for CMSSW_13_2_X.

Since this is the first PR for the development of HLT menus in this release cycle, the "fake" and "frozen" menus in the release are also updated accordingly.

This update includes the integration of the following JIRA tickets.

  • CMSHLT-2863: [TSG] replace instances of HLTPFJetTagWithMatching with HLTPFJetTag
  • CMSHLT-2888: [TRK] replace instances of SiPixelRawToClusterCUDA with SiPixelRawToClusterCUDAPhase1
  • CMSHLT-2891: [LUM] remove AlCaPCC streams from HIon menu

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#42610

Development of HLT menus for 2023/2024.

Development of HLT menus for `CMSSW_13_2_X`.

Since this is the first PR for the development of HLT menus in this release cycle, the "fake" and "frozen" menus in the release are also updated accordingly.

This update includes the integration of the following JIRA tickets.

 - [CMSHLT-2863](https://its.cern.ch/jira/browse/CMSHLT-2863): [TSG] replace instances of `HLTPFJetTagWithMatching` with `HLTPFJetTag`
 - [CMSHLT-2888](https://its.cern.ch/jira/browse/CMSHLT-2888): [TRK] replace instances of `SiPixelRawToClusterCUDA` with `SiPixelRawToClusterCUDAPhase1`
 - [CMSHLT-2891](https://its.cern.ch/jira/browse/CMSHLT-2891): [LUM] remove AlCaPCC streams from HIon menu
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 19, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_2_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e76f8/34368/summary.html
COMMIT: b052366
CMSSW: CMSSW_13_2_X_2023-08-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42611/34368/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 16 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196333
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196305
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.026 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): 0.013 KiB HLT/Filters
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

  • Outputs of the PR tests are in line with the update of the HLT menus ("frozen" and "fake" menus). Differences are only technical (e.g. menu names), no physics changes.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 26acc47 into cms-sw:CMSSW_13_2_X Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants