Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.2.X] add default for config and ComponentName in MkFitIterationConfigESProducer #42585

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 16, 2023

backport of #42584

PR description:

Title says it all, trivial technical PR in order to help parsing this parameter in confDB (needed to setup the HLT menu for 2023 Heavy Ions data-taking).

PR validation:

cmssw compiles.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #42584 to CMSSW_13_2_X for integration of the HLT menu for 2023 Heavy Ion data-taking.

Cc: @vince502 @denerslemos @cms-sw/hlt-l2

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 16, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_2_X.

It involves the following packages:

  • RecoTracker/MkFit (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich mmusich mentioned this pull request Aug 16, 2023
5 tasks
@mmusich
Copy link
Contributor Author

mmusich commented Aug 16, 2023

urgent

@mmusich
Copy link
Contributor Author

mmusich commented Aug 16, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a214f8/34320/summary.html
COMMIT: 8c2a3bb
CMSSW: CMSSW_13_2_X_2023-08-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42585/34320/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 21 lines from the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196338
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196307
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

@cms-sw/reconstruction-l2 @cms-sw/orp-l2 , kind ping.

This PR is part of the request for 13_2_1 (#42569).

@perrotta
Copy link
Contributor

+1

  • Straightforward, I assume @cms-sw/reconstruction-l2 won't complain if we bypass their signature

@missirol
Copy link
Contributor

Needs a "merge" by ORP.

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit d77d800 into cms-sw:CMSSW_13_2_X Aug 17, 2023
@mmusich mmusich deleted the default_forMkFitIterationConfigESProducer_13_2_X branch August 17, 2023 09:02
@jfernan2
Copy link
Contributor

+1
for the records

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants