Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_0_X (13/N) [13_3_X] #42570

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_13_0_X.

This is the PR for the master branch, which will then be backported down to 13_0_X (the latter is the release cycle currently used for Run-3 HLT-menu development).

This update includes the integration of the following JIRA ticket.

  • CMSHLT-2889: [TRK] add doublet-recovery tracks to EventContent of HLTMonitor stream

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_13_2_X
CMSSW_13_1_X
CMSSW_13_0_X

Development of HLT menus for `CMSSW_13_0_X`.

This update includes the integration of the following JIRA ticket.

 - [CMSHLT-2889](https://its.cern.ch/jira/browse/CMSHLT-2889): [TRK] add doublet-recovery tracks to EventContent of `HLTMonitor` stream
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42570/36588

  • This PR adds an extra 720KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

enable gpu

@missirol
Copy link
Contributor Author

test parameters:

  • enable = gpu
  • workflows = 141.041, 141.042, 141.046

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfd248/34292/summary.html
COMMIT: 0f24a54
CMSSW: CMSSW_13_3_X_2023-08-14-2300/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42570/34292/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 18 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3418844
  • DQMHistoTests: Total failures: 1479
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3417343
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 219 log files, 171 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 40118
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 40097
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

DQM differences are in line with the EventContent update described in CMSHLT-2889.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

ping bot

@cmsbuild cmsbuild merged commit 2b9536e into cms-sw:master Aug 15, 2023
@missirol missirol deleted the HLTdevelopment130X_for133X branch August 17, 2023 06:05
@slava77
Copy link
Contributor

slava77 commented Oct 12, 2023

type tracking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants