Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_1_X] Update the ZDC geometry fix and pixel conditions in MC GTs #42566

Merged

Conversation

consuegs
Copy link
Contributor

PR description:

Partial backport of #42551.

  • Updated the ZDC reco geometry tags requested in this CMSTalk post

    • For 2022 MC: ZDCRECO_Geometry_132DD4hepV2
    • For 2023 MC: ZDCRECO_Geometry_132DD4hepV3
  • Updated SiPixelDynIneff tag to SiPixelDynamicInefficiency_phase1_2023_v2_fix3 requested for 2022 realistic MC in this CMStalk post

  • Updated SiPixel BadComponents tags for 2022 realistic MC as requested in this CMSTalkPost:

    • pre-EE leak:
      SiPixelQuality_phase1_2022_v2b_mc
      SiPixelQuality_forDigitizer_phase1_2022_v2b_mc
    • post-EE leak:
      SiPixelQuality_phase1_2022_v5_mc
      SiPixelQuality_forDigitizer_phase1_2022_v5_mc

GT differences:

PR validation:

Tested with:

runTheMatrix -l 12034.0,12434.0,12834.0,11601.0 -j 8 --ibeos

Backport:

Partial backport of #42551

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 14, 2023

A new Pull Request was created by @consuegs for CMSSW_13_1_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@consuegs consuegs changed the title [13_1_X] Update the ZDC geoemtry fix in MC GTs [13_1_X] Update the ZDC geometry fix and pixel conditions in MC GTs Aug 14, 2023
@consuegs
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76e794/34271/summary.html
COMMIT: 4472b9e
CMSSW: CMSSW_13_1_X_2023-08-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42566/34271/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 18 lines to the logs
  • Reco comparison results: 2141 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3186945
  • DQMHistoTests: Total failures: 14070
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3172853
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Aug 14, 2023

+alca

  • tests pass
  • PR in line with description
  • lot of diff in plots but that's expected from the GT change

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #42551

@mmusich
Copy link
Contributor

mmusich commented Aug 15, 2023

backport of #42551

out of curiosity why targeting directly 13.1.X without a 13.2.X backport ? (of did I miss it?)

EDIT: yes the 13.2.X version is #42552 (certainly different PR titles don't help)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 994004a into cms-sw:CMSSW_13_1_X Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants