-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix elements_with_stride_nd when the index is outside the extent [13.1.x] #42560
Fix elements_with_stride_nd when the index is outside the extent [13.1.x] #42560
Conversation
Also: - add support for the AccCpuThreads acelerator - rename member variables for consistency - improve comments
type bugfix |
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_13_1_X. It involves the following packages:
@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport #42558 |
enable gpu |
please test with cms-sw/cmsdist#8647 |
+heterogeneous |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7617a7/34263/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
+1 |
PR description:
Extend
testKernel.dev.cc
with a 2D kernel test that uses large block sizes and redundant blocks.Fix
elements_with_stride_nd
when the initial index is outside the extent; this fixes the issue revealed by the new test.Also:
AccCpuThreads
accelerator;PR validation:
The new unit tests completes successfully.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #42558.