-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add customization function to remove check on Tracker DCS bits in Strip and Tracker DQM #42546
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42546/36560
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d3daf/34238/summary.html Comparison SummarySummary:
|
@cms-sw/dqm-l2 please let me know if I can help with the review. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/orp-l2 what's stopping integration? Please make a clearer suggestion at #42546 (comment) if you want me to change anything. I'd like to backport this all the way to 13.0.X in order to request a re-reco to address the issue described at #42546 (comment). |
+1 |
I think it's fine as is, it was a minor suggestion. |
PR description:
It is sometimes useful for private data certification checks to remove the DCS requirement on the Tracker partitions in the SiStrip and Tracking DQM monitors. This is generally applied in order to discard bad data, but it has been noticed several times in Run 3 (especially during cosmics data-taking) that the DCS information in the FEDRawData (obtained offline via
onlineMetaDataDigis
) is not 100% reliable.Moreover there has been at least one occurrence (for run 368343) in which a DCS issue which caused the TEC- DCS bit to be false till LS 990 of run 368343 (~9 am elog). As a consequence, the LS in the range [1-990] were discarded by the offline Strip and Tracking DQM (see this presentation) for more details.
This impedes the correct certification of that run.
PR validation:
I have run a modified
141.032
workflow using this customization function (as in mmusich@80e792e) in order to use LS=484 of run 368343, starting from the data in/ExpressPhysics/Run2023C-Express-v4/FEVT
and obtained filled Strip and Tracking Plots (which are otherwise empty).If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but will be backported to 13.0.X to request a re-reco of run 368343 (in order to be able to certify it offline)
Cc: @cardinia @sroychow