Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add customization function to remove check on Tracker DCS bits in Strip and Tracker DQM #42546

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 11, 2023

PR description:

It is sometimes useful for private data certification checks to remove the DCS requirement on the Tracker partitions in the SiStrip and Tracking DQM monitors. This is generally applied in order to discard bad data, but it has been noticed several times in Run 3 (especially during cosmics data-taking) that the DCS information in the FEDRawData (obtained offline via onlineMetaDataDigis) is not 100% reliable.
Moreover there has been at least one occurrence (for run 368343) in which a DCS issue which caused the TEC- DCS bit to be false till LS 990 of run 368343 (~9 am elog). As a consequence, the LS in the range [1-990] were discarded by the offline Strip and Tracking DQM (see this presentation) for more details.
This impedes the correct certification of that run.

PR validation:

I have run a modified 141.032 workflow using this customization function (as in mmusich@80e792e) in order to use LS=484 of run 368343, starting from the data in /ExpressPhysics/Run2023C-Express-v4/FEVT and obtained filled Strip and Tracking Plots (which are otherwise empty).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported to 13.0.X to request a re-reco of run 368343 (in order to be able to certify it offline)

Cc: @cardinia @sroychow

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42546/36560

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQM/SiStripMonitorClient (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 11, 2023

please test

  • even if there's nothing to test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d3daf/34238/summary.html
COMMIT: 8560e67
CMSSW: CMSSW_13_3_X_2023-08-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42546/34238/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150947
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3150919
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Aug 15, 2023

@cms-sw/dqm-l2 please let me know if I can help with the review.

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Aug 16, 2023

@cms-sw/orp-l2 what's stopping integration? Please make a clearer suggestion at #42546 (comment) if you want me to change anything. I'd like to backport this all the way to 13.0.X in order to request a re-reco to address the issue described at #42546 (comment).

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6eb2461 into cms-sw:master Aug 16, 2023
@rappoccio
Copy link
Contributor

I think it's fine as is, it was a minor suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants