HLT menu development for 13_0_X (12/N)
#42540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ESProducer siPixelQualityESProducer can be removed from the cff fragments of the HLT configurations, as it is provided by the cff file Configuration.StandardSequences.FrontierConditions_GlobalTag_cff This avoids picking up the version of siPixelQualityESProducer defined in ConfDB when a command like the following is used. cmsDriver.py step2 --conditions 130X_mcRun3_2023_realistic_relvals2023D_v1 \ --datatier GEN-SIM-DIGI-RAW --era Run3_2023 --eventcontent FEVTDEBUGHLT \ --filein "dbs:/RelValTTbar_14TeV/CMSSW_13_0_11-130X_mcRun3_2023_realistic_relvals2023D_v1_RV204-v1/GEN-SIM" \ --fileout "file:step2.root" --geometry DB:Extended --nThreads 8 --no_exec --number 1 \ --pileup 2023_Fills_8807_8901_ProjectedPileup_PoissonOOTPU \ --pileup_input das:/RelValMinBias_14TeV/CMSSW_13_0_11-130X_mcRun3_2023_realistic_relvals2023D_v1_RV204-v1/GEN-SIM \ --python_filename step_2_cfg.py --step DIGI:pdigi_valid,L1,DIGI2RAW,HLT:run3:/dev/CMSSW_13_0_0/GRun/V151 Using HLT:[db]:[config] (as opposed to HLT:[menuKeyword], e.g. HLT:GRun) leads to a call to the function loadHltConfiguration after the process has loaded FrontierConditions_GlobalTag_cff, thus overwriting the ESProducer from the latter cff with the one defined in the HLT configuration as taken from ConfDB. For details on a concrete use case, see https://its.cern.ch/jira/browse/PDMVRELVALS-204
Update of the scripts HLTrigger/Configuration/test/getHLT.sh , and HLTrigger/Configuration/test/getFrozenHLT.sh to use an associative array to specify which HLT configurations should be downloaded from ConfDB. This allows for more flexibility for non-standard use cases (e.g. having to specify different version numbers for different subtables). In getFrozenHLT.sh , this change also avoids having to specify the list of configurations in a separate string (which was named TABLES prior to this commit): now, it is sufficient to add a new configuration to the associative array. The downside of using associative arrays is that the configurations are not downloaded anymore in a specific order, but said order is (and should be) unimportant in this context.
Update of the functions "getHltConfiguration" and "loadHltConfiguration" defined in HLTrigger/Configuration/python/Utilities.py - remove unnecessary dependencies on external packages like "types" - fix "getHltConfiguration" (was broken since the changes in cms-sw#34563) - return cms.Process object in "loadHltConfiguration" (backward-compatible change) - add checks in both functions to catch errors in ConfDB queries
Development of HLT menus for `CMSSW_13_0_X`. This update includes the integration of the following JIRA tickets. - [CMSHLT-2820](https://its.cern.ch/jira/browse/CMSHLT-2820): [EXO] tighter isolation cut on L2Taus in displaced-tau trigger (and addition of backup trigger) - [CMSHLT-2836](https://its.cern.ch/jira/browse/CMSHLT-2836): [TSG] addition of looser L1T seeds to dilepton Scouting triggers - [CMSHLT-2862](https://its.cern.ch/jira/browse/CMSHLT-2862): [TRK,ECAL] use only CPU products in CPU branch of `DQMGPUvsCPU` triggers - [CMSHLT-2867](https://its.cern.ch/jira/browse/CMSHLT-2867): [EXO] remove Tracker-HV filters in calo-only LLP triggers - [CMSHLT-2872](https://its.cern.ch/jira/browse/CMSHLT-2872): [SMP] looser DiTau trigger for W-3pi search (plus control trigger) - [CMSHLT-2873](https://its.cern.ch/jira/browse/CMSHLT-2873): [AlCa] set smartPS=2 for `HLT_Physics_v` in `ExpressPhysics` PD - [CMSHLT-2874](https://its.cern.ch/jira/browse/CMSHLT-2874): [EXO,HIG] new VBF-parking triggers without PFJet-CHF cut - [CMSHLT-2875](https://its.cern.ch/jira/browse/CMSHLT-2875): [EXO] triggers for displaced mu-tau and e-tau final states - [CMSHLT-2877](https://its.cern.ch/jira/browse/CMSHLT-2877): [GEM] save GEM `FEDRawData` in `RPCMON` stream - [CMSHLT-2878](https://its.cern.ch/jira/browse/CMSHLT-2878): [TRK] add pixel-doublet-recovery iteration to standard tracking sequence, and disable track-looper reconstruction
|
A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_0_X. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25356a/34223/summary.html Comparison SummarySummary:
|
|
+hlt No changes in the outputs of PR tests (as expected), except for spurious DQM differences in some Phase-2 wfs (likely an occurrence of #39754). |
cmsbuild
added
hlt-approved
fully-signed
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #42537
PR description:
Development of HLT menus for
CMSSW_13_0_X.This update includes the integration of the following JIRA tickets.
DQMGPUvsCPUtriggersHLT_Physics_vinExpressPhysicsPDFEDRawDatainRPCMONstreamIn addition, the following updates relevant to HLT-menu development are included.
getHltConfigurationhltIntegrationTeststest/get*HLT.shscriptssiPixelQualityESProducerfrom HLTcfffilesL1Menu_Collisions2023_v1_3_0PR validation:
TSG tests.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
#42537
Development of HLT pp menus for 2023/2024.