[13.2.X] SiStripClusters2ApproxClusters: run peakFilter only if cluster is usable

[mmusich]

backport of #42486

PR description:

The goal of this PR is to solve the issues #42131 and #42132.
Those issues are caused because there is a condition (SiStripNoises) which is read off its domain from this call:

cmssw/RecoTracker/PixelLowPtUtilities/interface/SlidingPeakFinder.h

Line 72 in fe01c0e

cut_ = std::min<float>(seedCutMIPs * mip, seedCutSN * noiseObj_->getNoise(firstStrip + 1, noises_));

when it looks for the noise of strip n. 768 for Detid 369120277.
Having established at #42162 (comment) that for this detId (and similar modules), the strip range is from 0 to 767 (also independently, see mmusich@c1e1ca0), thus excluding possible issues with conditions, and following the line of thought that (see #42162 (comment)) a very similar code was already used in

cmssw/RecoTracker/PixelLowPtUtilities/src/StripSubClusterShapeTrajectoryFilter.cc

Line 84 in c2e865a

struct PeakFinderTest {

which I think it has been used since ever for the Strip seeded iterations, it begs the question on why this was not spotted before in StripSubClusterShapeTrajectoryFilter.
I propose in this PR to follow (almost) the same prescription used in that file before running the filter, namely using the output of ClusterShapeHitFilter::getSizes

cmssw/RecoTracker/PixelLowPtUtilities/src/StripSubClusterShapeTrajectoryFilter.cc

Lines 258 to 259 in c2e865a

	if (!usable)
	return true;

and the check on the measured (and predicted) cluster widths

cmssw/RecoTracker/PixelLowPtUtilities/src/StripSubClusterShapeTrajectoryFilter.cc

Lines 265 to 267 in c2e865a

	if (std::abs(hitPredPos) < 1.5f && hitStrips <= 2) {
	return true;
	}

Since ClusterShapeHitFilter::getSizes is not called with the measured trajectory direction, but rather with an approximated direction (the line joining the BeamSpot to the cluster) I enlarge the window to encompass 2 cluster pitches rather than 1.5.

PR validation:

In CMSSW_13_3_DBG_X_2023-08-01-2300 run successfully runTheMatrix.py -l 140.58 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #42486

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_2_X.

It involves the following packages:

• RecoLocalTracker/SiStripClusterizer (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@mtosi, @echabert, @VourMa, @GiacomoSguazzoni, @yduhm, @robervalwalsh, @JanFSchulte, @rovere, @gbenelli, @missirol, @threus, @felicepantaleo, @gpetruc, @mmusich, @VinInn, @alesaggio, @jlidrych this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from SiStripClusters2ApproxClusters: run peakFilter only if cluster is usable #42486

[mmusich]

test parameters:

• workflow = 140.58

[mmusich]

@cmsbuild, please test

[mmusich]

type bug-fix

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94abaf/34180/summary.html
COMMIT: 99b82cd
CMSSW: CMSSW_13_2_X_2023-08-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42516/34180/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 10 lines to the logs
• Reco comparison results: 54 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3257891
• DQMHistoTests: Total failures: 226
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3257643
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 161 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1