Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[131X] Pileup 2023 august #42510

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

malbouis
Copy link
Contributor

@malbouis malbouis commented Aug 8, 2023

PR description:

Backport of PR #42474

PR validation:

I didn't run any validation.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #42474 . To be backported all the way to 130X for the 2023 MC production.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2023

A new Pull Request was created by @malbouis (Helena Malbouisson) for CMSSW_13_1_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • SimGeneral/MixingModule (simulation)

@perrotta, @rappoccio, @civanch, @mdhildreth, @cmsbuild, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor Author

malbouis commented Aug 8, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-efae87/34165/summary.html
COMMIT: 44d8801
CMSSW: CMSSW_13_1_X_2023-08-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42510/34165/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3186945
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3186908
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@malbouis
Copy link
Contributor Author

malbouis commented Aug 9, 2023

@cms-sw/simulation-l2 , would you please sign this backport, in case you agree? Thanks!

@civanch
Copy link
Contributor

civanch commented Aug 9, 2023

+1

timeout is not related to this PR

@perrotta
Copy link
Contributor

perrotta commented Aug 9, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_3_X is complete.

@perrotta
Copy link
Contributor

perrotta commented Aug 9, 2023

merge

@cmsbuild cmsbuild merged commit 4d8f559 into cms-sw:CMSSW_13_1_X Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants