Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 HLT pixel modules duplicate removal (13_2_X backport) #42508

Merged

Conversation

lguzzi
Copy link
Contributor

@lguzzi lguzzi commented Aug 8, 2023

this is a backport of #42491.

PR description:

This PR removes some duplicated pixel modules from the phase2 menu and renames pixel[...] to hltPhase2Pixel[...]. More details in the master PR.
No change is expected. Some automated tests may fails because the pixelTracks and pixelVertices collections have been renamed to hltPhase2PixelTracks and hltPhase2PixelVertices as discussed in #42491 (comment).

PR validation:

tested privately running

cmsDriver.py Phase2 -s HLT:75e33 --processName=HLTX \
  --conditions auto:phase2_realistic_T21 \
  --geometry Extended2026D95 \
  --era Phase2C17I13M9 \
  --customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000 \
  --eventcontent FEVTDEBUGHLT \
  --filein /store/relval/CMSSW_13_2_0_pre3/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/131X_mcRun4_realistic_v6_2026D98noPU-v1/2580000/01b21771-37d5-41c2-b0ea-97bfce125a9a.root \
  -n 10 --nThreads 4

on 13_2_X. Output: results (baseline results as run on 689c030)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #42491, needed for the integration in the phase2 HLT.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2023

A new Pull Request was created by @lguzzi (Luca Guzzi) for CMSSW_13_2_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato, @SohamBhattacharya, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

missirol commented Aug 8, 2023

backport of #42491

@missirol
Copy link
Contributor

missirol commented Aug 8, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa07e3/34164/summary.html
COMMIT: 2ee29f5
CMSSW: CMSSW_13_2_X_2023-08-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42508/34164/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 8 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 134 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196338
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196306
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

missirol commented Aug 9, 2023

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 9, 2023

+1

@cmsbuild cmsbuild merged commit 175b096 into cms-sw:CMSSW_13_2_X Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants