Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace reference to ParameterSet with explicit parameter values in HcalTimeSlewEP #42502

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Aug 7, 2023

PR description:

This PR replaces a reference to edm::ParameterSet with explicitly parsed data structures for the configuration parameters. This change is needed in order to avoid keeping the top level ParameterSet alive throughout the job (and thus saving O(10 MB) of memory).

PR validation:

Workflow 11834.21 reco step runs.

Needed to avoid keeping the process PSet alive throughout the job, and
is generally more efficient anyway.
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42502/36508

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • CalibCalorimetry/HcalPlugins (alca)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@bsunanda, @mmusich, @abdoulline, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Aug 7, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c1657/34144/summary.html
COMMIT: 1db94a2
CMSSW: CMSSW_13_3_X_2023-08-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42502/34144/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150947
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3150919
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Aug 8, 2023

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 8, 2023

+1

@cmsbuild cmsbuild merged commit bf549db into cms-sw:master Aug 8, 2023
@makortel makortel deleted the hcalTimeSlewEPPSet branch August 8, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants