-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace reference to ParameterSet with explicit parameter values in HcalTimeSlewEP #42502
Conversation
Needed to avoid keeping the process PSet alive throughout the job, and is generally more efficient anyway.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42502/36508
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c1657/34144/summary.html Comparison SummarySummary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR replaces a reference to
edm::ParameterSet
with explicitly parsed data structures for the configuration parameters. This change is needed in order to avoid keeping the top levelParameterSet
alive throughout the job (and thus saving O(10 MB) of memory).PR validation:
Workflow 11834.21 reco step runs.