Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.2.X] Add default for FileName in TfGraphDefProducer::fillDescriptions() #42489

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 7, 2023

backport of #42488

PR description:

Title says it all, trivial technical PR in order to help parsing this parameter in confDB (needed to setup the HLT menu for 2023 Heavy Ions data-taking).

PR validation:

cmssw compiles.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #42488 for integration of the HLT menu for 2023 Heavy Ion data-taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_2_X.

It involves the following packages:

  • PhysicsTools/TensorFlow (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@makortel, @riga this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 7, 2023

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Aug 8, 2023

@cmsbuild, ping?

@mmusich
Copy link
Contributor Author

mmusich commented Aug 8, 2023

@cmsbuild, please abort

  • looks like tests were never started.

@perrotta
Copy link
Contributor

perrotta commented Aug 8, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-621025/34157/summary.html
COMMIT: 0b093e5
CMSSW: CMSSW_13_2_X_2023-08-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42489/34157/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 4.71DAS Error

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196338
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196303
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Aug 8, 2023

-1
Failed Tests: RelVals-INPUT

I guess we can forego this failure for now.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 8, 2023

urgent

  • @cms-sw/orp-l2 please flag this for the next 13_2_X release, it will be needed by TSG to finalize the HI menu.

@cmsbuild cmsbuild added the urgent label Aug 8, 2023
@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 9, 2023

+1

@perrotta
Copy link
Contributor

perrotta commented Aug 9, 2023

merge

@cmsbuild cmsbuild merged commit 4b63955 into cms-sw:CMSSW_13_2_X Aug 9, 2023
@mmusich mmusich deleted the default_for_TfGraphDefProducer_13_2_X branch August 9, 2023 05:41
@missirol missirol mentioned this pull request Aug 15, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants