Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.2.X] Update PrimaryVertexMonitor #42479

Merged
merged 2 commits into from
Aug 6, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 6, 2023

backport of #42359

PR description:

The purpose of this PR is to rationalize the code of PrimaryVertexMonitor in order to avoid unnecessary repetitions, also I am adding profile plots of the transverse and longitudinal impact parameter errors as a function of track eta and phi.

PR validation:

Privately checked runTheMatrix.py -l 140.063 -t 4 -j 8 --ibeos output.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #42359 to be used for 2023 Heavy Ion data-taking

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_2_X.

It involves the following packages:

  • DQMOffline/RecoB (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @AnnikaStein, @JyothsnaKomaragiri, @andrzejnovak, @demuller, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 6, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b4ca8/34105/summary.html
COMMIT: 85d3013
CMSSW: CMSSW_13_2_X_2023-08-06-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42479/34105/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3195458
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3195436
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 381.85399999999964 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 8.465 KiB OfflinePV/Alignment
  • DQMHistoSizes: changed ( 10024.0,... ): 8.527 KiB OfflinePV/Alignment
  • DQMHistoSizes: changed ( 12434.0,... ): 26.723 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 23234.0,... ): 9.371 KiB OfflinePV/Alignment
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 6, 2023

+1

@cmsbuild cmsbuild merged commit 689c030 into cms-sw:CMSSW_13_2_X Aug 6, 2023
@mmusich mmusich deleted the pvMonitorUpdates_13_2_X branch August 6, 2023 17:07
@slava77
Copy link
Contributor

slava77 commented Sep 13, 2023

type tracking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants