Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_1] Preserve electron mass after FastSim Bremsstrahlung emmision #42453

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Aug 2, 2023

PR description:

Backport of #42250

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2023

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_13_1_X.

It involves the following packages:

  • FastSimulation/SimplifiedGeometryPropagator (fastsim)

@cmsbuild, @ssekmen, @civanch, @mdhildreth, @sbein can you please review it and eventually sign? Thanks.
@matt-komm this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Aug 2, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b04d7/34042/summary.html
COMMIT: 16ad2f3
CMSSW: CMSSW_13_1_X_2023-08-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42453/34042/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 14 lines to the logs
  • Reco comparison results: 11397 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3186945
  • DQMHistoTests: Total failures: 22408
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3164515
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 3 / 46 workflows

@perrotta
Copy link
Contributor

perrotta commented Aug 3, 2023

backport of #42250

@perrotta
Copy link
Contributor

perrotta commented Aug 8, 2023

+1
(This was signed by fastsim in all other release cycles, I assume it would be also approved in 13_1_X)

@perrotta
Copy link
Contributor

perrotta commented Aug 8, 2023

merge

@cmsbuild cmsbuild merged commit e98ba86 into cms-sw:CMSSW_13_1_X Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants