Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0] Preserve electron mass after FastSim Bremsstrahlung emmision #42452

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Aug 2, 2023

PR description:

Backport of #42250

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2023

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_13_0_X.

It involves the following packages:

  • FastSimulation/SimplifiedGeometryPropagator (fastsim)

@cmsbuild, @ssekmen, @civanch, @mdhildreth, @sbein can you please review it and eventually sign? Thanks.
@matt-komm this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Aug 2, 2023

@cmsbuild please test

@sbein
Copy link
Contributor

sbein commented Aug 2, 2023

+1
Thanks Phat

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31410d/34041/summary.html
COMMIT: 1364196
CMSSW: CMSSW_13_0_X_2023-08-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42452/34041/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 194 lines from the logs
  • Reco comparison results: 10946 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3281270
  • DQMHistoTests: Total failures: 22285
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3258963
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 3 / 47 workflows

@perrotta
Copy link
Contributor

perrotta commented Aug 3, 2023

backport of #42250

@perrotta
Copy link
Contributor

perrotta commented Aug 8, 2023

+1 Thanks Phat

@sbein I imagine you wanted to approve for fastsim. However, if the"+1" is not in an isolated line, bot does not recognize it as an approval. I'm going to edit your comment, assuming this is what you meant

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@sbein
Copy link
Contributor

sbein commented Aug 8, 2023

+1

@sbein
Copy link
Contributor

sbein commented Aug 8, 2023

+1 Thanks Phat

@sbein I imagine you wanted to approve for fastsim. However, if the"+1" is not in an isolated line, bot does not recognize it as an approval. I'm going to edit your comment, assuming this is what you meant

Sorry! Thanks @perrotta!

@perrotta
Copy link
Contributor

perrotta commented Aug 8, 2023

+1

@cmsbuild cmsbuild merged commit 8c66f9b into cms-sw:CMSSW_13_0_X Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants