-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD validation: downgrade warning in BTL local reco validation #42432
MTD validation: downgrade warning in BTL local reco validation #42432
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42432/36443
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@smuzaffar the bot looks stuck... |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-796a4b/34009/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In #42257 a check on BTL recHits not corresponding to simHits was introduced, with a corresponding
LogWarning
message. This check is supposed to be valid if the full list of hits can be scanned, which is not the case in premixing. As a consequence, premixing processing log files are flooded with messages, that went unnoticed at the time of integration.This PR downgrades the
LogWarning
toLogDebug
, as a plot is available to monitor anyway the counting, and should be looked at depending of the kind of process is simulated.PR validation:
In wf 25034.999 step 4 warning messages disappear as expected.