Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD validation: downgrade warning in BTL local reco validation #42432

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Aug 1, 2023

PR description:

In #42257 a check on BTL recHits not corresponding to simHits was introduced, with a corresponding LogWarning message. This check is supposed to be valid if the full list of hits can be scanned, which is not the case in premixing. As a consequence, premixing processing log files are flooded with messages, that went unnoticed at the time of integration.

This PR downgrades the LogWarning to LogDebug, as a plot is available to monitor anyway the counting, and should be looked at depending of the kind of process is simulated.

PR validation:

In wf 25034.999 step 4 warning messages disappear as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42432/36443

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2023

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

  • Validation/MtdValidation (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Aug 1, 2023

please test

@fabiocos
Copy link
Contributor Author

fabiocos commented Aug 1, 2023

@smuzaffar the bot looks stuck...

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-796a4b/34009/summary.html
COMMIT: 6d30cad
CMSSW: CMSSW_13_3_X_2023-08-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42432/34009/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 26371 lines from the logs
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150821
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3150792
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 3, 2023

+1

@cmsbuild cmsbuild merged commit c2e865a into cms-sw:master Aug 3, 2023
@fabiocos fabiocos deleted the from-CMSSW_13_3_X_2023-07-31-2300 branch August 3, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants