Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 10_6_X] Fix EmissionVetoHook for BB4L #42422

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

lauridsj
Copy link
Contributor

PR description:

Backport of #42264 (fixing the Pythia FSR hook for bb4l) to CMSSW 10_6_X for UL MC generation, as discussed with @Saptaparna.

PR validation:

See #42264.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

See above.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lauridsj (Laurids Jeppe) for CMSSW_10_6_X.

It involves the following packages:

  • GeneratorInterface/Pythia8Interface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@Saptaparna
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c80ec/33987/summary.html
COMMIT: 1cf6041
CMSSW: CMSSW_10_6_X_2023-07-30-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42422/33987/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

You backported to 10_6 and 12_4
Please provide identical backports for 13_0, 13_1 and 13_2, so that there will not remain active cycles without this fix implemented

@lauridsj
Copy link
Contributor Author

lauridsj commented Aug 1, 2023

Hi, I made the three backports:
#42433
#42434
#42435

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

Thank you @lauridsj !

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

+1

@cmsbuild cmsbuild merged commit bf7ba25 into cms-sw:CMSSW_10_6_X Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants