Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_1_X] Output with additional histos for PU and tree with single module eff. #42403

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

jlagram
Copy link
Contributor

@jlagram jlagram commented Jul 28, 2023

Backport of the following PR initially made in CMSSW_13_2_X
#41845
Backport to CMSSW_13_1_X

Small changes to SiStripHitEffFromCalibTree.cc:
add the possibility as an option to output the efficiencies for each module, not only layer average
-> additional tree in the output root file
add PU/lumi distributions including the effect of the event selection based on track multiplicity
-> additional histos in the output root file

New distributions for PU info after cut on number of tracks

Fix a warning
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 28, 2023

A new Pull Request was created by @jlagram for CMSSW_13_1_X.

It involves the following packages:

  • CalibTracker/SiStripHitEfficiency (alca)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@echabert, @mmusich, @robervalwalsh, @gbenelli, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jul 28, 2023

backport of #41845

@mmusich
Copy link
Contributor

mmusich commented Jul 28, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d79c05/33951/summary.html
COMMIT: 74e1439
CMSSW: CMSSW_13_1_X_2023-07-27-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42403/33951/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3186945
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3186920
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jul 28, 2023

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Jul 28, 2023

@jlagram please include [13_1_X] in the PR title, thanks!

@jlagram jlagram changed the title Output with additional histos for PU and tree with single module eff. [13_1_X] Output with additional histos for PU and tree with single module eff. Jul 28, 2023
@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 34f9adc into cms-sw:CMSSW_13_1_X Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants