Add bit wise unity initialization for default LUT arrays

[aloeliger]

PR description:

(Potentially) fixes the other maybe-uninitialized warning present in #41794. This update initializes the default LUT arrays to a null value, then fills each with a bit-wise unity. I need to double check that this solution is acceptable to the calorimeter trigger experts, so it may get changed later.

@iarspider this should hopefully fix the remaining warnings in L1TCaloLayer1.

PR validation:

All code compiles, passes the code checks, and has had code formatting applied. Because this is slightly more than a trivial technical fix, I have also tested that runTheMatrix workflows run without obvious complaint

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42390/36409

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42390/36409/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42390/36409/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[aloeliger]

I thought I did the format anyways...

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42390/36410

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @aloeliger (Andrew Loeliger) for master.

It involves the following packages:

• L1Trigger/L1TCaloLayer1 (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test for CMSSW_13_3_CPP20_X
let's see if the warnings are gone

[cmsbuild]

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67a332/33932/summary.html
COMMIT: 69df040
CMSSW: CMSSW_13_3_CPP20_X_2023-07-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42390/33932/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 5.15.1_TTbarFS/step1_TTbarFS.log
• 135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
• 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log

Expand to see more relval errors ...

• 138.4
• 138.5
• 140.53
• 140.56
• 136.7611
• 136.88811
• 136.8311
• 2018.1
• 158.01
• 101.0
• 1000.0
• 1001.0
• 4.53
• 139.001
• 136.731
• 136.793
• 136.874
• 8.0
• 1306.0
• 1330.0
• 7.3
• 13234.0
• 10042.0
• 13434.0
• 9.0
• 312.0
• 25.0
• 11634.914
• 10024.0
• 2500.4
• 10824.0
• 11634.0
• 12434.7
• 12434.0
• 24900.0
• 25202.0
• 24896.0
• 11634.911
• 10224.0
• 24834.0
• 11834.0
• 23234.0
• 250202.181
• 25034.999
• 24834.911

AddOn Tests

• fastsim

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 5 sec (ended on Thu Jul 27 14:42:21 2023) - exit: 256

• fastsim1

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 3 sec (ended on Thu Jul 27 14:42:23 2023) - exit: 256

• fastsim2

[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 3 sec (ended on Thu Jul 27 14:42:24 2023) - exit: 256

Expand to see more addon errors ...

• hlt_mc_Fake
• hlt_mc_Fake1
• hlt_mc_Fake2
• hlt_mc_GRun
• hlt_mc_GRun
• hlt_mc_HIon
• hlt_mc_HIon
• hlt_mc_PIon
• hlt_mc_PIon
• hlt_mc_PRef
• hlt_mc_PRef
• hlt_data_Fake
• hlt_data_Fake1
• hlt_data_Fake2
• hlt_data_GRun
• hlt_data_GRun
• hlt_data_HIon
• hlt_data_HIon
• hlt_data_PIon
• hlt_data_PIon
• hlt_data_PRef
• hlt_data_PRef

[iarspider]

Warnings are gone, and test/relval failures are expected.

[aloeliger]

CaloL1 experts are reviewing whether they want an exception here instead of a default value in the case of no LUT loaded.

[aloeliger]

+l1

• Calo experts have signed off on this solution as okay for now.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67a332/34087/summary.html
COMMIT: 69df040
CMSSW: CMSSW_13_3_X_2023-08-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42390/34087/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 179 lines to the logs
• Reco comparison results: 57 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150821
• DQMHistoTests: Total failures: 342
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3150457
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

please test

I don't know what the following string, that appears in the logs of the bot tests, actually means

2023-08-04 18:35:27.719891: I tensorflow/core/util/port.cc:110] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`.

Let try testing once again, and see if the quite several differences in outputs (that shouldn't be expected, in my opinion) somehow disappear

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67a332/34096/summary.html
COMMIT: 69df040
CMSSW: CMSSW_13_3_X_2023-08-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42390/34096/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 14 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150821
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3150793
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+1