-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error code on fallback file open error with test, 12_5_X backport #42384
Conversation
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_12_5_X. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b33e44/33924/summary.html Comparison SummarySummary:
|
backport of #42249 |
+core |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Fix error code returned by cmsRun on a FallbackFileOpenError. There was a bug where it returns FileOpenError in the fallback case.
There is more discussion and more information related to this bug in issue #42040. FYI @stlammel
PR validation:
Includes new unit test. New unit test and existing tests pass. This should only affect the behavior after an exception occurs. It should not affect the output of successful cmsRun processes.
Backport of #42249.