clear badPixelDetsBarrel_ and badPixelDetsEndcap_ in PixelInactiveAreaFinder

[mmusich]

PR description:

Title says it all, potentially fix for the issue described at https://its.cern.ch/jira/browse/CMSHLT-2881 (Reproducibility issues with pixel-doublet-recovery iteration (GRun/V151 of 13_0_X)).

PR validation:

Run the script from @missirol 10 times and always obtained same trigger decisions.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported down to 13.0.X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42378/36406

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• RecoTracker/TkTrackingRegions (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

type bug-fix

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-007317/33915/summary.html
COMMIT: 4db219c
CMSSW: CMSSW_13_3_X_2023-07-26-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42378/33915/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 3487 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150117
• DQMHistoTests: Total failures: 9293
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3140802
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[slava77]

Reco comparison results: 3487 differences found in the comparisons

looking at a few cases, there are migrations from pixelPair step tracks (algo 6) to some other bins

e.g. TTbar13TeVPUppmx2018

it looks like everything is in the phase-1 workflows, as expected (no diffs in phase-2 or phase-0)

[mmusich]

@cms-sw/reconstruction-l2 please have a look. Integration of (backport of) this PR will be need to allow the introduction of the pixel doublet recovery in the next HLT menu.

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1