Add initial null value for model result in calo summary

[aloeliger]

PR description:

Adds an initial (null) value for the modelResult CICADA variable in L1TCaloSummary in response to #41794

@iarspider This should(?) hopefully silence some of the warning related to L1TCaloSummary.cc, but I can't do anything about build warnings that may belong to the ap_fixed type itself. I will look at the L1TCaloLayer1 plugin soon

PR validation:

All code compiles, passes code-checks, and has had code-formatting applied. In theory this should be a trivial technical fix that again shouldn't be able to mess anything else up.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport, or tied into any existing workflows.

[iarspider]

please test for CMSSW_13_3_CPP20_X

[iarspider]

Thanks @aloeliger ! Don't worry about warnings in hls (ap_fixed).

[aloeliger]

Thanks @aloeliger ! Don't worry about warnings in hls (ap_fixed).

@iarspider I'll try to take a look at the warnings in L1TCaloLayer1 too.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42376/36404

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @aloeliger (Andrew Loeliger) for master.

It involves the following packages:

• L1Trigger/L1TCaloLayer1 (l1)

@epalencia, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a7984/33913/summary.html
COMMIT: c01a677
CMSSW: CMSSW_13_3_CPP20_X_2023-07-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42376/33913/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
• 5.15.1_TTbarFS/step1_TTbarFS.log
• 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log

Expand to see more relval errors ...

• 138.4
• 138.5
• 140.53
• 140.56
• 136.88811
• 136.7611
• 136.8311
• 2018.1
• 158.01
• 101.0
• 1000.0
• 1001.0
• 4.53
• 139.001
• 136.874
• 136.731
• 136.793
• 8.0
• 1306.0
• 1330.0
• 7.3
• 13234.0
• 10042.0
• 13434.0
• 9.0
• 25.0
• 312.0
• 11634.914
• 10024.0
• 2500.4
• 10824.0
• 11634.0
• 12434.0
• 12434.7
• 24900.0
• 24896.0
• 25202.0
• 11634.911
• 10224.0
• 24834.0
• 11834.0
• 23234.0
• 25034.999
• 250202.181
• 24834.911

AddOn Tests

• fastsim

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 6 sec (ended on Wed Jul 26 15:55:07 2023) - exit: 256

• fastsim1

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 3 sec (ended on Wed Jul 26 15:55:09 2023) - exit: 256

• fastsim2

[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 2 sec (ended on Wed Jul 26 15:55:11 2023) - exit: 256

Expand to see more addon errors ...

• hlt_mc_Fake
• hlt_mc_Fake1
• hlt_mc_Fake2
• hlt_mc_GRun
• hlt_mc_GRun
• hlt_mc_HIon
• hlt_mc_HIon
• hlt_mc_PIon
• hlt_mc_PIon
• hlt_mc_PRef
• hlt_mc_PRef
• hlt_data_Fake
• hlt_data_Fake1
• hlt_data_Fake2
• hlt_data_GRun
• hlt_data_GRun
• hlt_data_HIon
• hlt_data_HIon
• hlt_data_PIon
• hlt_data_PIon
• hlt_data_PRef
• hlt_data_PRef

[aloeliger]

Hmm, this shouldn't be able to fail any relVals, it doesn't run in any current path.

[aloeliger]

ModuleNotFoundError: No module named 'RecoTracker.PixelSeeding.pixelTripletHLTEDProducerDefault_cfi'

This seems to be the common error. This doesn't seem like something I have introduced.

[iarspider]

@aloeliger ah, sorry, should've worded that explicitly in #41794: the only thing left to fix are these warnings in
L1Trigger/L1TCaloLayer1/plugins/L1TCaloLayer1.cc:

warning: 'eCalLayer1EtaSideEtArray' may be used uninitialized [-Wmaybe-uninitialized]
warning: 'hCalLayer1EtaSideEtArray' may be used uninitialized [-Wmaybe-uninitialized]
warning: 'hfLayer1EtaEtArray' may be used uninitialized [-Wmaybe-uninitialized]
warning: 'hfLayer1EtaEtArray' may be used uninitialized [-Wmaybe-uninitialized]

[iarspider]

And RelVal/test failures are expected, since CPP20 IBs are broken by other issues.

[aloeliger]

@aloeliger ah, sorry, should've worded that explicitly in #41794: the only thing left to fix are these warnings in L1Trigger/L1TCaloLayer1/plugins/L1TCaloLayer1.cc:

warning: 'eCalLayer1EtaSideEtArray' may be used uninitialized [-Wmaybe-uninitialized]
warning: 'hCalLayer1EtaSideEtArray' may be used uninitialized [-Wmaybe-uninitialized]
warning: 'hfLayer1EtaEtArray' may be used uninitialized [-Wmaybe-uninitialized]
warning: 'hfLayer1EtaEtArray' may be used uninitialized [-Wmaybe-uninitialized]

Okay, I'm looking at these, but they appear to be triply nested std::array's that seem to want to be defaulting to unity for all elements of what appears to be a std::array<std::array<std::array<uint_32, 256>, 2>, 28>. Not sure the best way to go about that...

[aloeliger]

After reading further, I'm not even sure what we consider unity here given that the LUT is used in some bitwise operation in the towers themselves (i.e. is unity 1? doesn't make sense from a bit perspective. Is unity 1 for all bits? Is it 0?). I will be meeting with the calo trigger group today in any case, I'll try to sort out an answer from the experts then.

[aloeliger]

+l1

• This PR is fine since I maintain this file anyways. The other fix I am still waiting to hear back on.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

please test
(run tests also in the production branch)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a7984/33958/summary.html
COMMIT: c01a677
CMSSW: CMSSW_13_3_X_2023-07-27-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42376/33958/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150821
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3150793
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+1