-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve discover method in cond2xml for read-only and patch releases #42357
Improve discover method in cond2xml for read-only and patch releases #42357
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42357/36389
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-494ce4/33876/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Starting from the discussion in #42292 and following Marino's suggestion in missirol@ea229a8, this PR fixes the way in which
conddb
retrieves thepluginUtilities_payload2xml.so
library to dump payload content, especially for patch releases.Note: The issue was already nicely solved in #42324, this PR simply rewrites some code to make it more clear (at least more clear to me). Additionally, it fixes the Exception printout message in case "No XML converter is found..."
PR validation:
Code compiles plus a few local tests using the
discover
function that is updated here.Backport:
Not a backport, but to be backported all the way back to 13_0_X.