Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2023 FastSim Era #42346

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Add 2023 FastSim Era #42346

merged 2 commits into from
Jul 27, 2023

Conversation

srimanob
Copy link
Contributor

PR description:

This PR follows the new Era of Run_3 2023 in #41271
This PR needs to be used with #42327 to complete FastSim setup for 2023.

PR validation:

Run private production and compare DQM. One can see better FastSim-FullSim agreement with new era:

For all plots:

  • Black: FullSim (private)
  • Blue: FastSim (default, same GEN as FullSim)
  • Orange: FastSim (New era, same GEN as FullSim)
  • Red: FullSim (relvals, as ref)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Need backport to 13_0, 13_1, 13_2

@srimanob
Copy link
Contributor Author

test parameters:

  • pull_request = Update 2023 FastSim beamspot #42327
  • workflows = 14034.0,14234.0
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42346/36368

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)

@perrotta, @rappoccio, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @sunilUIET, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @AnnikaStein, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1eff35/33860/summary.html
COMMIT: c89e832
CMSSW: CMSSW_13_3_X_2023-07-24-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42346/33860/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1eff35/33860/git-merge-result

@srimanob
Copy link
Contributor Author

test parameters:

@srimanob
Copy link
Contributor Author

test parameters:

  • workflows = 14034.0,14234.0
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42346/36373

@cmsbuild
Copy link
Contributor

Pull request #42346 was updated. @perrotta, @rappoccio, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @sunilUIET, @fabiocos, @davidlange6 can you please check and sign again.

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1eff35/33863/summary.html
COMMIT: 2045b1a
CMSSW: CMSSW_13_3_X_2023-07-24-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42346/33863/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1eff35/33863/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1eff35/33863/git-merge-result

Comparison Summary

Summary:

  • You potentially added 57 lines to the logs
  • Reco comparison results: 2436 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3198802
  • DQMHistoTests: Total failures: 2639
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196141
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 212 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 47 workflows

@srimanob
Copy link
Contributor Author

+Upgrade

Fail in wf 14034.0 comparison is expected, it is 2023 FastSim workflow. No change is expected in other workflow.

@srimanob
Copy link
Contributor Author

Kindly ping @cms-sw/pdmv-l2

@sunilUIET
Copy link
Contributor

+pdmv

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants