add layer-TSOS compatibility check in LayerMeasurements

[missirol]

PR description:

This PR includes a possibile solution for the issue discussed in #40174 (see that issue for details), thanks to suggestions from @cms-sw/tracking-pog-l2.

#42318 contains a different solution for the same issue. The two PRs are not mutually exclusive (in principle, both could be integrated).

In this PR, a check is added to LayerMeasurements in order to skip TrajectoryStateOnSurface objects whose global position is well outside the detector volume. The rationale of this check was discussed in #40174 (comment).

PR validation:

Manual checks with the reproducers in #40174 (comment) and #40174 (comment).

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

TBD

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42320/36348

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• TrackingTools/MeasurementDet (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @bellan, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42320/36349

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #42320 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7ff3f/33805/summary.html
COMMIT: d495adf
CMSSW: CMSSW_13_3_X_2023-07-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42320/33805/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 12 lines from the logs
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3197149
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3197126
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction
Fix for HLT crash by requiring a reasonable projected rechit position which is not far away from CMS.
No changes observed in comparisons, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[missirol]

Given the changes in data-taking schedule, I guess a backport to 13_0_X is not so useful anymore (assuming it would have been accepted). I would still backport this to 13_2_X, unless somebody objects.

[rappoccio]

+1

I think it doesn't hurt to have the 13_0_X backport as well, unless there are some conflicts.