-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HLT tracks in alignment validation #42302
Support HLT tracks in alignment validation #42302
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42302/36325
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@perrotta, @consuegs, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
…ns in TrackerTrackHitFilter
1580275
to
f3d75bb
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42302/36326
|
Pull request #42302 was updated. @perrotta, @consuegs, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please check and sign again. |
test parameters:
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-391cb9/33770/summary.html Comparison SummarySummary:
|
+alca
|
The tracker alignment team has performed internal validation using |
Looks great, thanks @lakshmip2609 ! |
@cms-sw/reconstruction-l2 ping |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@cms-sw/orp-l2, if I want this to be backported to 13.0.x can you clarify now how many and which backports do we need? All cycles in between (13.2.x, 13.1x, 13.0.x)? |
@mmusich yes having the same fixes/updates in all intermediate cycles is the preferred options, unless there are reasons to avoid any of them |
PR description:
It is in the plans to start using
hltMergedTracks
from theSteamHLTMonitor
PD in the tracker alignment procedure in order to minimize the drift between the derived alignment correction / validations and their actual usage in production (at the HLT).This PR proposes a couple of minimal fixes in order to be able to run the standard setup.
There are two commits:
hltMergedTracks
collection in the common track selection and refitting sequenceSiStripMatchedRecHit2D
andProjectedSiStripRecHit2D
collections inTrackerTrackHitFilter
. Encountering hits from either of these two collections was leading to a runtime exception of the type:These two collections (as the previously stated in the removed comment) did not happen anymore since CMSSW > 2_0_X because of hit splitting in stereo modules in offline reconstruction, but in HLT tracking stereo hit splitting is not performed.
In order to cope with the
SiStripMatchedRecHit2D
, the cut on the S/N is performed by taking the average of the stereo and mono hits.PR validation:
Tested the minimal configuration provided by @henriettepetersen (available here).
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport. Not clear at this point if a backport for 2023 to 13.0.X is useful or not.