Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HLT tracks in alignment validation #42302

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 19, 2023

PR description:

It is in the plans to start using hltMergedTracks from the SteamHLTMonitor PD in the tracker alignment procedure in order to minimize the drift between the derived alignment correction / validations and their actual usage in production (at the HLT).
This PR proposes a couple of minimal fixes in order to be able to run the standard setup.
There are two commits:

  • 7e521a4 supports the hltMergedTracks collection in the common track selection and refitting sequence
  • 1580275 supports the SiStripMatchedRecHit2D and ProjectedSiStripRecHit2D collections in TrackerTrackHitFilter. Encountering hits from either of these two collections was leading to a runtime exception of the type:
----- Begin Fatal Exception 05-Jul-2023 19:33:49 CEST-----------------------
An exception of category 'Unknown RecHit Type' occurred while
   [0] Processing  Event run: 370102 lumi: 668 event: 1557577232 stream: 0
   [1] Running path 'p'
   [2] Calling method for module TrackerTrackHitFilter/'TrackerTrackHitFilter'
   
Exception Message:
RecHit of type 22SiStripMatchedRecHit2D not supported. (use c++filt to demangle the name)
----- End Fatal Exception -------------------------------------------------

These two collections (as the previously stated in the removed comment) did not happen anymore since CMSSW > 2_0_X because of hit splitting in stereo modules in offline reconstruction, but in HLT tracking stereo hit splitting is not performed.
In order to cope with the SiStripMatchedRecHit2D, the cut on the S/N is performed by taking the average of the stereo and mono hits.

PR validation:

Tested the minimal configuration provided by @henriettepetersen (available here).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. Not clear at this point if a backport for 2023 to 13.0.X is useful or not.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42302/36325

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Alignment/CommonAlignment (alca)
  • RecoTracker/FinalTrackSelectors (reconstruction)

@perrotta, @consuegs, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks.
@pakhotin, @VourMa, @adewit, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @missirol, @rovere, @tlampen, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich mmusich force-pushed the support_hlt_tracks_in_alignment_validation branch from 1580275 to f3d75bb Compare July 19, 2023 09:31
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42302/36326

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

Pull request #42302 was updated. @perrotta, @consuegs, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 19, 2023

test parameters:

  • addpkg = Alignment/OfflineValidation
  • workflows = 1001.2, 1001.3

@mmusich
Copy link
Contributor Author

mmusich commented Jul 19, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-391cb9/33770/summary.html
COMMIT: f3d75bb
CMSSW: CMSSW_13_3_X_2023-07-18-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42302/33770/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3210569
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3210542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 161 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jul 19, 2023

+alca

  • tests pass
  • trusting private alignment validation

@lakshmip2609
Copy link

The tracker alignment team has performed internal validation using hltMergedTracks from the SteamHLTMonitor PD after implementing the fix proposed in this PR. The validation ran successfully, and the obtained results look reasonable. We would like to leave here a link to a presentation summarising this study to serve as a future reference: https://indico.cern.ch/event/1271491/#16-validation-of-conditions-wi

@tvami
Copy link
Contributor

tvami commented Jul 20, 2023

Looks great, thanks @lakshmip2609 !

@mmusich
Copy link
Contributor Author

mmusich commented Jul 24, 2023

@cms-sw/reconstruction-l2 ping

@clacaputo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ce38079 into cms-sw:master Jul 24, 2023
@mmusich
Copy link
Contributor Author

mmusich commented Jul 24, 2023

@cms-sw/orp-l2, if I want this to be backported to 13.0.x can you clarify now how many and which backports do we need? All cycles in between (13.2.x, 13.1x, 13.0.x)?

@mmusich mmusich deleted the support_hlt_tracks_in_alignment_validation branch July 24, 2023 18:05
@perrotta
Copy link
Contributor

@cms-sw/orp-l2, if I want this to be backported to 13.0.x can you clarify now how many and which backports do we need? All cycles in between (13.2.x, 13.1x, 13.0.x)?

@mmusich yes having the same fixes/updates in all intermediate cycles is the preferred options, unless there are reasons to avoid any of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants