Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_2_X] Revert BeamSpot fallback logic #42297

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Verbatim backport of #42284
This PR reverts the online BeamSpot fallback logic to actually fall back to the DB, ie. to consume the last BeamSpot produced by PCL.

PR validation:

See master PR for validation

Backport:

Backport of #42284

mmusich and others added 3 commits July 17, 2023 15:31
@cmsbuild cmsbuild added this to the CMSSW_13_2_X milestone Jul 18, 2023
@francescobrivio
Copy link
Contributor Author

francescobrivio commented Jul 18, 2023

backport of #42284

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 18, 2023

A new Pull Request was created by @francescobrivio for CMSSW_13_2_X.

It involves the following packages:

  • DQM/BeamMonitor (dqm, db)
  • RecoVertex/BeamSpotProducer (reconstruction, alca)

@perrotta, @consuegs, @micsucmed, @nothingface0, @emanueleusai, @clacaputo, @tvami, @cmsbuild, @saumyaphor4252, @pmandrik, @syuvivida, @tjavaid, @mandrenguyen, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks.
@VourMa, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @tocheng, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

test parameters:

  • addpkg = DQM/Integration

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38dbfd/33744/summary.html
COMMIT: b21e838
CMSSW: CMSSW_13_2_X_2023-07-18-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42297/33744/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 71 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3195634
  • DQMHistoTests: Total failures: 39
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3195573
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • 13_0 backport tested at p5 successfully

@mandrenguyen
Copy link
Contributor

+1

@francescobrivio
Copy link
Contributor Author

+db

@saumyaphor4252
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ffa736d into cms-sw:CMSSW_13_2_X Jul 20, 2023
@francescobrivio francescobrivio deleted the alca-revert_BS_fallback_logic branch July 11, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants