Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Add HARVEST step to SKIM WF for Run3 #42289

Merged

Conversation

youyingli
Copy link
Contributor

Backport of #42277

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 18, 2023

A new Pull Request was created by @youyingli (You-Ying Li) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • DPGAnalysis/Skims (pdmv)

@cmsbuild, @bbilin, @srimanob, @sunilUIET, @AdrianoDee can you please review it and eventually sign? Thanks.
@makortel, @AnnikaStein, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@youyingli
Copy link
Contributor Author

@srimanob @sunilUIET please consider triggering this PR and sign it later

@srimanob
Copy link
Contributor

test parameters:

  • workflows = 141.101,141.102,141.103,141.104,141.105,141.106,141.107,141.108,141.109,141.110,141.111,141.112,141.113,141.114
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@srimanob
Copy link
Contributor

@cmsbuild please test

@srimanob
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-826dd9/33833/summary.html
COMMIT: d9f8bc1
CMSSW: CMSSW_13_0_X_2023-07-21-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42289/33833/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 843 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3281270
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3281245
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 269 log files, 218 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@sunilUIET
Copy link
Contributor

@perrotta can you please put your comment here so that @youyingli can answer it? Thanks

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

@youyingli the 13_0_X (this one) and 13_1_X (#42291) backports are different: could you please explain why?
In particular 13_0_X is identical to 13_2_X (#42296), while only the backport to 13_1_X includes also the backport of #42107, #42229...

@youyingli
Copy link
Contributor Author

@perrotta , the backports of #42107, #42229 to 13_0_X is in #42232. At that time, the backport of these two PRs(#42107 and #42229) to 13_1_X was not available as #42226 was not merged (I mentioned in #42232 (comment)). After #42226 was merged, since #42277 also needed to be backported to 13_1_X and 13_0_X, the backport to 13_1_X is #42107, #42229 and #42277, while only #42277 is backported to 13_0_X (this PR).

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

+1

@cmsbuild cmsbuild merged commit 092dd4c into cms-sw:CMSSW_13_0_X Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants