Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0.X] add DQM and Validation modules for doublet recovery tracks #42279

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 17, 2023

backport of #42266

PR description:

With the inclusion of the hltDoubletRecoveryPFlowTrackSelectionHighPurity collection to the track reconstruction at HLT,
there is now the need of monitoring and validating it as well
This PR simply extend the already in place DQM and Validation sequences to include this collection as well
Not having the HLT menu w/ this extra collection in CMSSW, the expected output is to have empty plots, but the code will run

PR validation:

Relies on the master version

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #42266 for 2023 data-taking

@mmusich
Copy link
Contributor Author

mmusich commented Jul 17, 2023

cc: @mtosi

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 17, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_0_X.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)
  • DQMOffline/Trigger (dqm)
  • Validation/RecoTrack (dqm)

@Martin-Grunewald, @nothingface0, @emanueleusai, @cmsbuild, @missirol, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@trocino, @Fedespring, @VourMa, @silviodonato, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @HuguesBrun, @ebrondol, @jhgoh, @wmtford, @mmusich, @mtosi, @dgulhan, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 17, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1310dd/33713/summary.html
COMMIT: 09afdde
CMSSW: CMSSW_13_0_X_2023-07-16-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42279/33713/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 266 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3286334
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 16
  • DQMHistoTests: Total successes: 3286287
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4657.544 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): 2328.772 KiB HLT/Tracking
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 91e9721 into cms-sw:CMSSW_13_0_X Jul 18, 2023
@mmusich mmusich deleted the doubletRecoveryDQMatHLT_13_0_X branch July 18, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants