(DAQ) Fix early too file deletion for error stream 13_2_X

[smorovic]

PR description:

Use correct vector to loop over tracking of files opened for each stream.
Fixed for FedRawDataInputSource and DAQSource

PR validation:

Fixed and tested in DAQ test setup.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42258/36281

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @smorovic (Srecko Morovic) for master.

It involves the following packages:

• EventFilter/Utilities (daq)

@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smorovic]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23785f/33686/summary.html
COMMIT: c242531
CMSSW: CMSSW_13_2_X_2023-07-13-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42258/33686/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @bsunanda Phase2-hgx341H Modify several test scripts in Geometry/HGCalCommonData to test geometry versions beyond the first V17 #42252
• @youyingli Update skim config for 2023 data taking and fix wrong assignment in skim wf #42229
• @bsunanda Phase2-hgx341G Next step toward the V18 version of HGCal by making mixed module with passive volumes #42251
• @JaLuka98 Add hasConversionTracks to nano #42247

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23785f/33686/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23785f/33686/git-merge-result

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 88 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3193892
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3193870
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.08 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 0.136 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 13234.0,... ): 0.064 KiB Physics/NanoAODDQM
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smorovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1