Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_0_X (11/N) [13_2_X] #42218

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Jul 9, 2023

PR description:

Development of HLT menus for CMSSW_13_0_X.

This is the PR for the master branch, which will then be backported down to 13_0_X (the latter is the release cycle currently used for Run-3 HLT-menu development).

This update includes the integration of the following JIRA tickets.

  • CMSHLT-2841: [TSG] cleanup of EventContent of hltOutputReleaseValidation
  • CMSHLT-2844: [TSG] remove PSet named transferSystem
  • CMSHLT-2845: [TSG] remove HLT_ExpressMuons_v trigger
  • CMSHLT-2846: [TRK] add SiPixelRawDataError collections to EventContent of DQMGPUvsCPU stream
  • CMSHLT-2847: [TSG] add PS column "2p0E34_NoEcalTiming"
  • CMSHLT-2848: [TSG] remove 7 unused PS columns
  • CMSHLT-2854: [L1T] remove outdated L1T seeds for VBF triggers
  • CMSHLT-2858: [L1T] remove extra L1T seeds ahead of L1TMenu2023-v1_3_0
  • CMSHLT-2864: [TSG] remove redundant PS columns "1p3E34", "1p0E34", and "0p8E34"
  • CMSHLT-2870: [TSG] set PS=0 for AlCa_PFJet40_CPUOnly_v in "2p1E34" PS column

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_13_1_X
CMSSW_13_0_X

Development of HLT menus for `CMSSW_13_0_X`.

This update includes the integration of the following JIRA tickets.

 - [CMSHLT-2841](https://its.cern.ch/jira/browse/CMSHLT-2841): [TSG] cleanup of EventContent of `hltOutputReleaseValidation`
 - [CMSHLT-2844](https://its.cern.ch/jira/browse/CMSHLT-2844): [TSG] remove PSet named `transferSystem`
 - [CMSHLT-2845](https://its.cern.ch/jira/browse/CMSHLT-2845): [TSG] remove `HLT_ExpressMuons_v` trigger
 - [CMSHLT-2846](https://its.cern.ch/jira/browse/CMSHLT-2846): [TRK] add `SiPixelRawDataError` collections to EventContent of `DQMGPUvsCPU` stream
 - [CMSHLT-2847](https://its.cern.ch/jira/browse/CMSHLT-2847): [TSG] add PS column "2p0E34_NoEcalTiming"
 - [CMSHLT-2848](https://its.cern.ch/jira/browse/CMSHLT-2848): [TSG] remove 7 unused PS columns
 - [CMSHLT-2854](https://its.cern.ch/jira/browse/CMSHLT-2854): [L1T] remove outdated L1T seeds for VBF triggers
 - [CMSHLT-2858](https://its.cern.ch/jira/browse/CMSHLT-2858): [L1T] remove extra L1T seeds ahead of `L1TMenu2023-v1_3_0`
 - [CMSHLT-2864](https://its.cern.ch/jira/browse/CMSHLT-2864): [TSG] remove redundant PS columns "1p3E34", "1p0E34", and "0p8E34"
 - [CMSHLT-2870](https://its.cern.ch/jira/browse/CMSHLT-2870): [TSG] set PS=0 for `AlCa_PFJet40_CPUOnly_v` in "2p1E34" PS column
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42218/36227

  • This PR adds an extra 716KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Jul 9, 2023

enable gpu

@missirol
Copy link
Contributor Author

missirol commented Jul 9, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3cba7/33608/summary.html
COMMIT: deb1b37
CMSSW: CMSSW_13_2_X_2023-07-09-0000/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42218/33608/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 26 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3193890
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3193865
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.016 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): -0.008 KiB HLT/Filters
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 40086
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 40065
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

The plots of the DQM bin-by-bin comparisons are not available, maybe this is related to #42050 (the same issue applies to other recent PRs unrelated to HLT). The available info from PR tests does not show anything unexpected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c2ba821 into cms-sw:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants