-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pileup scenario for 2023 simulation #42213
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42213/36222 |
A new Pull Request was created by @romeof for master. It involves the following packages:
@rappoccio, @civanch, @mdhildreth, @cmsbuild, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Hi Francesco, thank you for the PR! |
This PR includes the information to simulate the pileup scenario for the 2023 simulation samples. |
Thanks a lot! Would you also please edit the very first comment on top of this PR, to include the description there? |
please test |
@romeof , you may edit a description and/or a title of any PR at any time. So, for this particular case, you simply copy your comment and insert into the description. |
thanks for comments. let me know if anything else is left to do. |
-1 Failed Tests: RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
please test the problem is in timeout not relevant to this PR but let us repeat the test. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-493202/33602/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+1 |
please test again timeout not related to this PR |
If you know that it is not related, why do you care? |
+1 what we should do in this case? |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-493202/33622/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
@romeof do we expect also backports of this PR? |
Hi @mmusich , yes, we would like to have backports, specially to 13_0_X |
Since I would like this to be integrated urgently for this ticket, I've taken the liberty of opening them: |
Marco, do I have to do anything at this point? It seems like you went ahead with the backporting. |
no, assuming the backport integration goes smoothly, there should not be anything else to do on your side. Thanks! |
PR description:
This PR includes the information to simulate the pileup scenario for the 2023 simulation samples. We rely on part of RunC data (fills 8807 to 8901) to generate such pileup distribution. More details have been discussed in the PPD General Meeting (see link https://indico.cern.ch/event/1299290/).
PR validation:
The added code has been tested with CMSSW_13_2_0_pre2, using the root file /store/relval/CMSSW_13_0_0_pre4/RelValMinBias_13p6TeV/GEN-SIM/130X_mcRun3_2022_realistic_withNewBSFromEOY2022Data_v1_RV186-v1/00000/18441d91-eeb9-46a9-bc4a-f5c388ef5e27.root