Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pileup scenario for 2023 simulation #42213

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

romeof
Copy link
Contributor

@romeof romeof commented Jul 7, 2023

PR description:

This PR includes the information to simulate the pileup scenario for the 2023 simulation samples. We rely on part of RunC data (fills 8807 to 8901) to generate such pileup distribution. More details have been discussed in the PPD General Meeting (see link https://indico.cern.ch/event/1299290/).

PR validation:

The added code has been tested with CMSSW_13_2_0_pre2, using the root file /store/relval/CMSSW_13_0_0_pre4/RelValMinBias_13p6TeV/GEN-SIM/130X_mcRun3_2022_realistic_withNewBSFromEOY2022Data_v1_RV186-v1/00000/18441d91-eeb9-46a9-bc4a-f5c388ef5e27.root

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42213/36222

  • This PR adds an extra 28KB to repository

  • Found files with invalid states:

    • SimGeneral/MixingModule/python/mix_2023_25ns_Fills_8807_8901_ProjectedPileup_PoissonOOTPU_cfi.py:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2023

A new Pull Request was created by @romeof for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • SimGeneral/MixingModule (simulation)

@rappoccio, @civanch, @mdhildreth, @cmsbuild, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor

malbouis commented Jul 7, 2023

Hi Francesco, thank you for the PR!
Would you please also include a description of this PR, for future reference?
Thanks!

@romeof
Copy link
Contributor Author

romeof commented Jul 7, 2023

This PR includes the information to simulate the pileup scenario for the 2023 simulation samples.
We rely on part of RunC data (fills 8807 to 8901) to generate such pileup distribution.
More details have been discussed in the PPD General Meeting (see link https://indico.cern.ch/event/1299290/).

@malbouis
Copy link
Contributor

malbouis commented Jul 7, 2023

This PR includes the information to simulate the pileup scenario for the 2023 simulation samples. We rely on part of RunC data (fills 8807 to 8901) to generate such pileup distribution. More details have been discussed in the PPD General Meeting (see link https://indico.cern.ch/event/1299290/).

Thanks a lot! Would you also please edit the very first comment on top of this PR, to include the description there?

@civanch
Copy link
Contributor

civanch commented Jul 7, 2023

please test

@civanch
Copy link
Contributor

civanch commented Jul 7, 2023

@romeof , you may edit a description and/or a title of any PR at any time. So, for this particular case, you simply copy your comment and insert into the description.

@romeof
Copy link
Contributor Author

romeof commented Jul 7, 2023

thanks for comments. let me know if anything else is left to do.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-493202/33590/summary.html
COMMIT: 30107a1
CMSSW: CMSSW_13_2_X_2023-07-06-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42213/33590/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-493202/33590/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-493202/33590/git-merge-result

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3193892
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3193861
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jul 7, 2023

please test

the problem is in timeout not relevant to this PR but let us repeat the test.
We should likely backport this PR to 13_1_X and 13_0_X for any case, even if DIGI step will not run at these releases

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-493202/33602/summary.html
COMMIT: 30107a1
CMSSW: CMSSW_13_2_X_2023-07-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42213/33602/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.897 step 2
140.025 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 21 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3193892
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3193864
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jul 7, 2023

+1

@civanch
Copy link
Contributor

civanch commented Jul 10, 2023

please test

again timeout not related to this PR

@perrotta
Copy link
Contributor

again timeout not related to this PR

If you know that it is not related, why do you care?

@civanch
Copy link
Contributor

civanch commented Jul 10, 2023

+1

what we should do in this case?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-493202/33622/summary.html
COMMIT: 96ca9f2
CMSSW: CMSSW_13_2_X_2023-07-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42213/33622/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3193892
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3193861
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@mmusich
Copy link
Contributor

mmusich commented Jul 11, 2023

@romeof do we expect also backports of this PR?
@malbouis @jordan-martins

@malbouis
Copy link
Contributor

@romeof do we expect also backports of this PR? @malbouis @jordan-martins

Hi @mmusich , yes, we would like to have backports, specially to 13_0_X
@romeof , would you please go ahead with the backports?

@mmusich
Copy link
Contributor

mmusich commented Jul 11, 2023

would you please go ahead with the backports

Since I would like this to be integrated urgently for this ticket, I've taken the liberty of opening them:

@romeof
Copy link
Contributor Author

romeof commented Jul 11, 2023

Marco, do I have to do anything at this point? It seems like you went ahead with the backporting.

@mmusich
Copy link
Contributor

mmusich commented Jul 11, 2023

Marco, do I have to do anything at this point?

no, assuming the backport integration goes smoothly, there should not be anything else to do on your side. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants