Fixing crash when accessing JetResolutionObject in CondDB

[yuanchao]

PR description:

For the crashes found while accessing the JetResolutionObject in CondDB, it's found that the bins and variables are empty with Definiton::getBins() and Definition::getVariables(). This causes segmentation violation when calling JetResolutionObject::getRecord(). As not seen in XML dump, the formula is obtained through the formula string. Later found that Definition::nBins() is actually check from the bin-name strings. This PR changes Definition::nVariables() accordingly. Also make new function overloading on createVector to access through name strings. Minimum changes to get around the crashes.

PR validation:

Tested locally with getPayLoadData.py on modified PI to make sure no seg. fault. Python binding parts are not touched.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport and no backport is expected.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42199/36205

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @yuanchao (Yuan CHAO) for master.

It involves the following packages:

• CondFormats/JetMETObjects (db)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mmusich, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

This is a memory leak. Better to do

 reco::FormulaEvaluator formula{m_definition.getFormulaString()};

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42199/36224

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #42199 was updated. @perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please check and sign again.

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29afda/33601/summary.html
COMMIT: 3097d89
CMSSW: CMSSW_13_2_X_2023-07-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42199/33601/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.897 step 2
140.025 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 8 lines to the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3193892
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3193864
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tvami]

+db

• tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1