Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] lhcInfo split: per fill and per LS PopCon #42197

Merged

Conversation

JanChyczynski
Copy link
Contributor

PR description:

Backport of #40817

Adding the PopCon scripts and plugins to populate the LHCInfoPerLS and LHCInfoPerFill records. Includes the unit test for the new PopCons.

PR validation:

See master PR for validation description

Backport

Backport of #40817

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2023

A new Pull Request was created by @JanChyczynski (jan_chyczynski) for CMSSW_13_0_X.

It involves the following packages:

  • CondTools/RunInfo (db)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@JanChyczynski JanChyczynski changed the title lhcInfo split: per fill and per LS PopCon [13_0_X] lhcInfo split: per fill and per LS PopCon Jul 6, 2023
@francescobrivio
Copy link
Contributor

backport of #40817

@francescobrivio
Copy link
Contributor

@cmsbuild please test

  • eventually need a new 13_0_X for putting in production the new LHCInfo O2Os

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b31e4/33567/summary.html
COMMIT: 8f81525
CMSSW: CMSSW_13_0_X_2023-07-05-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42197/33567/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially added 249 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3317116
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3317091
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

@cmsbuild please test

  • timed out relvals are not critical, but we have time to re-try them since this PR is not super critical

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b31e4/33577/summary.html
COMMIT: 8f81525
CMSSW: CMSSW_13_0_X_2023-07-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42197/33577/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 252 lines from the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3317116
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3317088
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+1

  • tests clean

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

We also need a CMSSW_13_1_X branch of this, please.

@francescobrivio
Copy link
Contributor

We also need a CMSSW_13_1_X branch of this, please.

Hi Sal, the master PR #40817 is already in 13_1_X, but back in that time we did not made a 13_0_X backpor, which we now realized we need.

@perrotta
Copy link
Contributor

perrotta commented Jul 7, 2023

+1

@cmsbuild cmsbuild merged commit 297524b into cms-sw:CMSSW_13_0_X Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants