Run3-hcx345 Try to fix ieta=16 issue for HCAL simulation in the GEN-SIM step

[bsunanda]

PR description:

Try to fix ieta=16 issue for HCAL simulation in the GEN-SIM step

PR validation:

Tested using the script SimG4CMS/Calo/test/python/ttbar.py

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

May need to backport a part of this PR to CMSSW versions 13_0_X and 13_1_X

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42105/36081

• This PR adds an extra 44KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42105/36081/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42105/36081/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42105/36082

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HcalCommonData (geometry)
• SimG4CMS/Calo (simulation)

@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @thomreis, @wang0jin, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[bsunanda]

Type Bug-fix

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a5ee6/33413/summary.html
COMMIT: c8d61ec
CMSSW: CMSSW_13_2_X_2023-06-26-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42105/33413/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 154 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 43650 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3200270
• DQMHistoTests: Total failures: 90734
• DQMHistoTests: Total nulls: 12
• DQMHistoTests: Total successes: 3109502
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.6920000000000002 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.371 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 1.893 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.182 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.352 KiB SiStrip/MechanicalView
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 8 / 46 workflows

[abdoulline]

@bsunanda
2023 MC test of this PR with 1k muon gun shot at |ieta|=16 (eta=1.3-1.4, phi= -pi +pi)
confirmed that there is no any instance of |ieta|=16 depth1 with the weight other than 1.0.

[perrotta]

@bsunanda @abdoulline could any of you expert summarize in the PR description what is the "ieta=16 issue" that this PR wants to fix?
These PRs are often a bit cryptic if one wants to understand what the problem was and how do you plan to fix it...

[civanch]

@bsunanda , please, comment out debugging.

[bsunanda]

done

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42105/36092

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #42105 was updated. @civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[bsunanda]

There is layer 1 in eta=16. Sometimes the edge of eta=15 in layer 1 is assigned as eta=16. Though these are rare cases, this happens and it is avoided here. So it is a safer version

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a5ee6/33420/summary.html
COMMIT: 0744a6d
CMSSW: CMSSW_13_2_X_2023-06-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42105/33420/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 164 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 43658 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3200270
• DQMHistoTests: Total failures: 90741
• DQMHistoTests: Total nulls: 12
• DQMHistoTests: Total successes: 3109495
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.6920000000000002 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.371 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 1.893 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.182 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.352 KiB SiStrip/MechanicalView
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 8 / 46 workflows

[bsunanda]

@civanch Please approve it now

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1