[13_0_X] APE measurement tool: Resolved python3 compatibility issues, added unit test functionality, removed dependency on other package: Backport of #42012

[mteroerd]

PR description:

autoSubmitter.py did not run on recent CMSSW releases since ROOT does not work with python2, while python3 execution would throw an error from using the output of "check_output" without decode().

Some additional small changes to remove redundancies were applied, as well as a change to the disk space requested by condor jobs (the target input file size is 350MB, but files can be larger than 400MB anyway) and some formatting changes. Also, the method names now adhere to the CMS naming rules.

Additionally, added unit test functionality and removed the need to add the package Alignment/TrackerAlignment whenever a measurement is to be performed.

PR validation:

I executed the program with an example configuration and made sure it ran as expected. All changes should be transparent.
Also, a unit test can now be run to validate the PR.

Backport

Backport of #42012
Slight change since unit tests use a different working folder in this CMSSW release.

[cmsbuild]

A new Pull Request was created by @mteroerd (Marius Teroerde) for CMSSW_13_0_X.

It involves the following packages:

• Alignment/APEEstimation (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @adewit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from APE measurement tool: Resolved python3 compatibility issues, added unit test functionality, removed dependency on other package #42012

[mmusich]

type bug-fix

[mmusich]

please test

[mmusich]

backport of #42012

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6e1dd/33383/summary.html
COMMIT: 7c2e663
CMSSW: CMSSW_13_0_X_2023-06-25-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42085/33383/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 267 lines to the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3317136
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3317111
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mmusich]

just a kind ping to @cms-sw/alca-l2 concerning this and the other backport

[francescobrivio]

Thanks for the ping!
The master PR also contains the deletion of:

• Alignment/APEEstimation/test/testApeestimatorSummary_cfg.py
• Alignment/APEEstimation/test/testApeestimator_cfg.py

Should that be backported here (and in the 13_1_X backport) as well?

[mteroerd]

Hi Francesco,
I forgot to include their removal in the backports. However, this will not create any problems related to any functionality. In fact, I removed them because they are unused code. So from my side, I do not think they have to be removed here.

[francescobrivio]

+1

• tests ok and new unitTest is successful
• left for a possible followup PR (i.e. not critical): [13_0_X] APE measurement tool: Resolved python3 compatibility issues, added unit test functionality, removed dependency on other package: Backport of #42012 #42085 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1