Run3-hcx342 Try to fix the issue of HCAL hit relabeller

[bsunanda]

PR description:

Try to fix the issue of HCAL hit relabeler. This is a bug fix

PR validation:

Use the new test code in Geometry/HcalCommonData/test and its test script in .../test/python directories

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Need the bug fix to be back ported to CMSSW_13_1_X and CMSSW_13_0_X

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42083/36067

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42083/36067/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42083/36067/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42083/36068

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HcalCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[abdoulline]

@bsunanda Thanks!

[bsunanda]

@cmsbuild Please test

[bsunanda]

Type Bug Fix

[malbouis]

urgent

• we need the backport of this fix to be integrated in the 130X release for the 2023 MC production.

[malbouis]

type bug-fix

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42083/36079

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42083/36079/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42083/36079/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42083/36080

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #42083 was updated. @makortel, @bsunanda, @civanch, @Dr15Jones, @mdhildreth can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c736c/33406/summary.html
COMMIT: 97ffdb8
CMSSW: CMSSW_13_2_X_2023-06-26-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42083/33406/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 11 lines from the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3200270
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3200243
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[bsunanda]

+geometry

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[abdoulline]

Hi @bsunanda
I'm a bit confused to see no difference w/wo PR
#42083 (comment)

Idem for both 13_0_X and 13_1_X backports...

[rappoccio]

+1