Making a new Secondary Dataset ReserveDMu #42065

jordan-martins · 2023-06-23T07:46:44Z

This PR is constrained at /Configuration/Skimming:

creates Configuration/Skimming/python/PDWG_ReserveDMu_SD_cff.py to make the HLT path selection for the new proposed SD. It is intended to run on the ParkingDoubleMuonLowMass PD
creates a test file Configuration/Skimming/test/test_ReserveDMu_SD_cfg.py
updates Configuration/Skimming/python/Skims_PDWG_cff.py with the desired data tier for the SD
updates the Configuration/Skimming/python/autoSkim.py to be picked up automatically either in T0 or in further ReRECOS

I am adding a new cff to handle the creation of a SD.

Adding the PDWG_ReserveDMu_SD_cff file

Adding the ReserveDMu SD for all the ParkingDoubleMuonLowMass PDs

Test file for the ReserveDMu Secondary Dataset

cmsbuild · 2023-06-23T07:55:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42065/36043

This PR adds an extra 24KB to repository

cmsbuild · 2023-06-23T07:55:39Z

A new Pull Request was created by @jordan-martins (Jordan Martins) for master.

It involves the following packages:

Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @sunilUIET, @kskovpen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos, @youyingli this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

jordan-martins · 2023-06-23T08:14:12Z

please test

cmsbuild · 2023-06-23T09:33:40Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a0b84/33353/summary.html
COMMIT: 59093f2
CMSSW: CMSSW_13_2_X_2023-06-22-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42065/33353/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

1000.0

----- Begin Fatal Exception 23-Jun-2023 10:43:40 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing  Event run: 165121 lumi: 62 event: 23609118 stream: 0
   [1] Running path 'ReserveDMuPath'
   [2] Calling method for module HLTHighLevel/'ReserveDMu'
Exception Message:
requested pattern "HLT_Dimuon0_Jpsi3p5_Muon2_v*" does not match any HLT paths
----- End Fatal Exception -------------------------------------------------

trtomei · 2023-06-23T13:54:29Z

I guess that path was not available in Run2011 :)

jordan-martins · 2023-06-23T17:11:29Z

please test

cmsbuild · 2023-06-23T17:18:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42065/36054

This PR adds an extra 16KB to repository

cmsbuild · 2023-06-23T17:18:59Z

Pull request #42065 was updated. @bbilin, @sunilUIET can you please check and sign again.

cmsbuild · 2023-06-23T19:33:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a0b84/33368/summary.html
COMMIT: 6a58feb
CMSSW: CMSSW_13_2_X_2023-06-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42065/33368/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 14 lines to the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3200270
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3200242
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

youyingli · 2023-06-24T12:40:40Z

@jordan-martins. Thanks for the help. Could this PR need to backport to 13_1_X and 13_0_X for data taking?

perrotta · 2023-06-26T14:08:49Z

@cms-sw/pdmv-l2 you signed the 13_0_X backport: can we suppose that you also agree with this master version, and you can sign it (and the 13_1_X backport as well). Could you please confirm (with a "+1")

@jordan-martins @cms-sw/pdmv-l2 could you please also confirm that these changes will not be effective until explicitly switched on at Tier0? (In other words, it is not dangerous for data taking even if the 13_0_X version is merged in parallel with this master version)

sunilUIET · 2023-06-26T14:11:52Z

+1

@cms-sw/pdmv-l2 you signed the 13_0_X backport: can we suppose that you also agree with this master version, and you can sign it (and the 13_1_X backport as well). Could you please confirm (with a "+1")

@jordan-martins @cms-sw/pdmv-l2 could you please also confirm that these changes will not be effective until explicitly switched on at Tier0? (In other words, it is not dangerous for data taking even if the 13_0_X version is merged in parallel with this master version)

perrotta

Please, if you need to update further these files remove the explicit types, which is a safer way to code these configurations (not for this PR)

perrotta · 2023-06-26T14:12:18Z

Configuration/Skimming/python/PDWG_ReserveDMu_SD_cff.py

+ReserveDMu.TriggerResultsTag = cms.InputTag( "TriggerResults", "", "HLT" )
+ReserveDMu.HLTPaths = cms.vstring(


Suggested change

ReserveDMu.TriggerResultsTag = cms.InputTag( "TriggerResults", "", "HLT" )

ReserveDMu.HLTPaths = cms.vstring(

ReserveDMu.TriggerResultsTag = ( "TriggerResults", "", "HLT" )

ReserveDMu.HLTPaths = [

perrotta · 2023-06-26T14:12:54Z

Configuration/Skimming/python/PDWG_ReserveDMu_SD_cff.py

+    'HLT_Tau3Mu_Mu7_Mu1_TkMu1_Tau15_Charge1_v*',
+    'HLT_Tau3Mu_Mu7_Mu1_TkMu1_Tau15_v*',
+    'HLT_Trimuon5_3p5_2_Upsilon_Muon_v*',
+    'HLT_TrimuonOpen_5_3p5_2_Upsilon_Muon_v*')


Suggested change

'HLT_TrimuonOpen_5_3p5_2_Upsilon_Muon_v*')

'HLT_TrimuonOpen_5_3p5_2_Upsilon_Muon_v*']

perrotta · 2023-06-26T14:13:09Z

Configuration/Skimming/python/PDWG_ReserveDMu_SD_cff.py

+    'HLT_Tau3Mu_Mu7_Mu1_TkMu1_Tau15_v*',
+    'HLT_Trimuon5_3p5_2_Upsilon_Muon_v*',
+    'HLT_TrimuonOpen_5_3p5_2_Upsilon_Muon_v*')
+ReserveDMu.andOr = cms.bool( True )


Suggested change

ReserveDMu.andOr = cms.bool( True )

ReserveDMu.andOr = True

perrotta · 2023-06-26T14:13:32Z

Configuration/Skimming/python/PDWG_ReserveDMu_SD_cff.py

+# we want to intentionally throw and exception
+# in case it does not match one of the HLT Paths
+# set to False now, switch to on once matrix is updated
+ReserveDMu.throw = cms.bool( False )


Suggested change

ReserveDMu.throw = cms.bool( False )

ReserveDMu.throw = False

cmsbuild · 2023-06-26T14:16:10Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-06-26T14:16:27Z

+1

jordan-martins added 4 commits June 23, 2023 09:25

Create PDWG_ReserveDMu_SD_cff.py

9e2ba84

I am adding a new cff to handle the creation of a SD.

Update Skims_PDWG_cff.py

12c5ba7

Adding the PDWG_ReserveDMu_SD_cff file

Update autoSkim.py

16c7ed9

Adding the ReserveDMu SD for all the ParkingDoubleMuonLowMass PDs

Create test_ReserveDMu_SD_cfg.py

59093f2

Test file for the ReserveDMu Secondary Dataset

cmsbuild added this to the CMSSW_13_2_X milestone Jun 23, 2023

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending code-checks-pending labels Jun 23, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 23, 2023

cmsbuild added tests-started and removed tests-pending labels Jun 23, 2023

cmsbuild added tests-rejected and removed tests-started labels Jun 23, 2023

Update PDWG_ReserveDMu_SD_cff.py

6a58feb

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Jun 23, 2023

cmsbuild added tests-started and removed tests-pending labels Jun 23, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 23, 2023

cmsbuild added tests-approved and removed tests-started labels Jun 23, 2023

This was referenced Jun 25, 2023

back port of #42065 #42081

Closed

Secondary Dataset backport 130X #42084

Merged

Secondary Dataset backport 131X #42088

Merged

perrotta reviewed Jun 26, 2023

View reviewed changes

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Jun 26, 2023

cmsbuild added orp-approved and removed orp-pending labels Jun 26, 2023

cmsbuild merged commit 27ea50b into cms-sw:master Jun 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Making a new Secondary Dataset ReserveDMu #42065

Making a new Secondary Dataset ReserveDMu #42065

jordan-martins commented Jun 23, 2023

cmsbuild commented Jun 23, 2023

cmsbuild commented Jun 23, 2023

jordan-martins commented Jun 23, 2023

cmsbuild commented Jun 23, 2023

trtomei commented Jun 23, 2023

jordan-martins commented Jun 23, 2023

cmsbuild commented Jun 23, 2023

cmsbuild commented Jun 23, 2023

cmsbuild commented Jun 23, 2023

youyingli commented Jun 24, 2023

perrotta commented Jun 26, 2023

sunilUIET commented Jun 26, 2023 •

edited by perrotta

Loading

perrotta left a comment

perrotta Jun 26, 2023

perrotta Jun 26, 2023

perrotta Jun 26, 2023

perrotta Jun 26, 2023

cmsbuild commented Jun 26, 2023

perrotta commented Jun 26, 2023

		ReserveDMu.TriggerResultsTag = cms.InputTag( "TriggerResults", "", "HLT" )
		ReserveDMu.HLTPaths = cms.vstring(

	'HLT_TrimuonOpen_5_3p5_2_Upsilon_Muon_v*')
	'HLT_TrimuonOpen_5_3p5_2_Upsilon_Muon_v*']

	ReserveDMu.throw = cms.bool( False )
	ReserveDMu.throw = False

Making a new Secondary Dataset ReserveDMu #42065

Making a new Secondary Dataset ReserveDMu #42065

Conversation

jordan-martins commented Jun 23, 2023

cmsbuild commented Jun 23, 2023

cmsbuild commented Jun 23, 2023

jordan-martins commented Jun 23, 2023

cmsbuild commented Jun 23, 2023

RelVals

trtomei commented Jun 23, 2023

jordan-martins commented Jun 23, 2023

cmsbuild commented Jun 23, 2023

cmsbuild commented Jun 23, 2023

cmsbuild commented Jun 23, 2023

Comparison Summary

youyingli commented Jun 24, 2023

perrotta commented Jun 26, 2023

sunilUIET commented Jun 26, 2023 • edited by perrotta Loading

perrotta left a comment

Choose a reason for hiding this comment

perrotta Jun 26, 2023

Choose a reason for hiding this comment

perrotta Jun 26, 2023

Choose a reason for hiding this comment

perrotta Jun 26, 2023

Choose a reason for hiding this comment

perrotta Jun 26, 2023

Choose a reason for hiding this comment

cmsbuild commented Jun 26, 2023

perrotta commented Jun 26, 2023

sunilUIET commented Jun 26, 2023 •

edited by perrotta

Loading