Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

131X update for TopMuEG skim #42064

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

soureek
Copy link

@soureek soureek commented Jun 23, 2023

PR description:

Updating HLT paths for TopMuEG skim in 13_1_X.
Related to #42057

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 23, 2023

A new Pull Request was created by @soureek (Soureek Mitra) for CMSSW_13_1_X.

It involves the following packages:

  • DPGAnalysis/Skims (pdmv)

@cmsbuild, @bbilin, @sunilUIET, @kskovpen can you please review it and eventually sign? Thanks.
@youyingli, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@kskovpen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-358cad/33361/summary.html
COMMIT: cf5dc6e
CMSSW: CMSSW_13_1_X_2023-06-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42064/33361/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222811
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3222787
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@kskovpen
Copy link
Contributor

+pdmv

@perrotta
Copy link
Contributor

backport of #42066

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@@ -550,6 +542,7 @@
'keep TotemVFATStatusedmDetSetVector_ctppsDiamondRawToDigi_*_*',
'keep CTPPSDiamondRecHitedmDetSetVector_ctppsDiamondRecHits_*_*',
'keep CTPPSDiamondLocalTrackedmDetSetVector_ctppsDiamondLocalTracks_*_*',
'keep TotemTimingLocalTrackedmDetSetVector_diamondSampicLocalTracks_*_*',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following keep statements were present in the master version of this PR, but missing here:

        'keep TotemFEDInfos_totemT2Digis_*_*',
        'keep TotemT2DigiedmNewDetSetVector_totemT2Digis_*_*',
        'keep TotemVFATStatusedmDetSetVector_totemT2Digis_*_*',

Since this is a test script it does not prevent getting merged, but probably it is something you want to have a look at, @soureek

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perrotta The test python file is generated with cmsDriver command using the options listed in L5. The conditions are taken from 2022 setup. I did not add or remove anything here.

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7871597 into cms-sw:CMSSW_13_1_X Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants