Addition of HLT_Ele30_WPTight_Gsf to OfflineDQM and cleanups

[RSalvatico]

The purpose of this PR is to:

• add HLT_Ele30_WPTight_Gsf to the OfflineDQM among the monitored paths in HLT/EGM/TagAndProbeEffs, as requested by TSG in CMSHLT-2810;
• change the offline electron and photon IDs for EGM to the newest Run3 ones (electrons, photons);
• clean up, removing HEM/HEP plots (which were relevant in 2017) and removing trigger paths which are no longer in the menu.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42049/36029

• This PR adds an extra 28KB to repository

[RSalvatico]

type egamma

[swagata87]

type egamma

[cmsbuild]

A new Pull Request was created by @RSalvatico (Riccardo Salvatico) for master.

It involves the following packages:

• DQMOffline/Trigger (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[RSalvatico]

please test

[swagata87]

Hello @smuzaffar @perrotta
(sorry if you are not responsible for this, in that case kindly redirect to those who are responsible).
Currently the POG L2s have rights to issue test commands etc. But as you know the POG L2s are changing soon.
From EGamma side we would like the incoming L2 Riccardo to be added to the list so that he has rights.
Is it something that will be taken care of centrally by you? Or should we make PRs ourselves to add him to the list?
Thank you!

[swagata87]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfb1a7/33341/summary.html
COMMIT: 16b867c
CMSSW: CMSSW_13_2_X_2023-06-22-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42049/33341/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 538 lines to the logs
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3193531
• DQMHistoTests: Total failures: 2875
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3190634
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1497.2569999999998 KiB( 47 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): -262.021 KiB HLT/EGM
• DQMHistoSizes: changed ( 12434.0,... ): -324.405 KiB HLT/EGM
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

Hello @smuzaffar @perrotta (sorry if you are not responsible for this, in that case kindly redirect to those who are responsible). Currently the POG L2s have rights to issue test commands etc. But as you know the POG L2s are changing soon. From EGamma side we would like the incoming L2 Riccardo to be added to the list so that he has rights. Is it something that will be taken care of centrally by you? Or should we make PRs ourselves to add him to the list? Thank you!

@swagata87 , please open a PR for cms-bot and add the new L2.

[emanueleusai]

can you explain why this PR yields change in PAG's HLT DQM paths such as DQM/SUSY, etc?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_2_X_2023-06-22-1100+dfb1a7/57638/12434.0_TTbar_14TeV+2023/HLT_SUSY.html

[RSalvatico]

Hi, I am on holiday and not able to browse the code much. The differences you point out seem to be related to electron HLT paths. One of the changes I have made concerns the electron IDs for the tag&probe that we use to measure trigger efficiencies. I suspect that these PAG's DQMs inherit that from EGM. Different offline IDs --> different efficiencies.

[emanueleusai]

makes sense, thanks for looking into it

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1