add layer-1 monitoring for new slot-7 cards [13_2_0_pre1]

[hftsoi]

PR description:

This PR modifies Calo-Layer1 unpacker to adapt the additions of a new CTP7 card in slot-7 in each of the three layer-1 crates (FEDs 1354, 1356, 1358), where each card sends the same payload header and trailer as all other existing calo cards, but with a fixed payload data size of 6 32-bit words, regardless of normal or FAT events being sent. New monitoring elements are added to layer-1 DQM for the 3x6x32 bits. The modification is done in such a way that it works before and after the card addition.

Note that the monitoring elements for HCAL FB4-5 are commented out, we will put them back once HCAL fixes them (FB4-5 are reserved bits and not used for LLP, but they are sending unphysical data there which layer-1 could not read out, causing discrepancies seen when comparing them).

PR validation:

Validated by running offline DQM on past commissioning runs, it works as expected for current production firmware. Tested with online DQM at P5 with new firmware.

#42021 is a backport of this master PR.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42048/36028

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @hftsoi (Ho-Fung Tsoi) for master.

It involves the following packages:

• DQM/L1TMonitor (dqm)
• EventFilter/L1TRawToDigi (l1)

@aloeliger, @epalencia, @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @Martin-Grunewald, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[emanueleusai]

type l1t

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea683e/33348/summary.html
COMMIT: b431267
CMSSW: CMSSW_13_2_X_2023-06-22-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42048/33348/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3200230
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3200202
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -925.8799999999998 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): -46.294 KiB L1T/L1TStage2CaloLayer1
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

• I think L1 is fine with this just to keep it in line with the backport that was tested at P5. @emanueleusai does DQM need any tests of this on CMSSW_13_2?

[emanueleusai]

@aloeliger thanks for the heads up! The 13_0 backport of this PR ( #42021 ) is tested and deployed at P5 already, see #42021 (comment)
We do not have 13_2 or master IBs installed on our machines as we stick with production releases.

[emanueleusai]

+1

[hftsoi]

@hftsoi would you mind squashing the 11 commits into a single one?

no problem, please. thank you

[perrotta]

@hftsoi would you mind squashing the 11 commits into a single one?

no problem, please. thank you

I meant... could you please squash the commits? (Sorry if I was not clear on it)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42048/36100

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #42048 was updated. @aloeliger, @epalencia, @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again.

[emanueleusai]

+1

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea683e/33434/summary.html
COMMIT: 092b5b7
CMSSW: CMSSW_13_2_X_2023-06-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42048/33434/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3193812
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3193787
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -925.8799999999998 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): -46.294 KiB L1T/L1TStage2CaloLayer1
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1