Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved fill descriptions for PoolOutputModule #42038

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Added description for what happens when pass a negative number to eventAutoFlushCompressedSize.

PR validation:

Compiles. [Only the documentation string was changed]

Added description for what happens when pass a negative number
to eventAutoFlushCompressedSize.
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42038/36019

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • IOPool/Output (core)

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-096e8e/33305/summary.html
COMMIT: 7117113
CMSSW: CMSSW_13_2_X_2023-06-20-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42038/33305/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-096e8e/33305/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-096e8e/33305/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
24834.0 step 1
24834.21 step 1
24834.5 step 1
24834.911 step 1
24834.9 step 1
25034.114 step 1
25034.21 step 1
25034.9921 step 1
25034.999 step 1
25034.99 step 1
25061.97 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 3607 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 1086444
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1086428
  • DQMHistoTests: Total skipped: 16
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 24 files compared)
  • Checked 123 log files, 58 edm output root files, 25 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

+1

Simple addition of documentation, can't affect any application (and therefore I don't think rerunning the tests would be worth it)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c6c69cf into cms-sw:master Jun 22, 2023
@Dr15Jones Dr15Jones deleted the descriptionsPoolOutputModule branch July 14, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants