Remove obsolete FinalStateReconOption from Herwig7 shower settings

[lmoureaux]

PR description:

This parameter was removed and the old default is now the only option. Specifying it prevents showering with Herwig. See https://herwig.hepforge.org/doxygen/KinematicsReconstructorInterfaces.html (bottom of the page)

PR validation:

Showered a fragment in CMSSW_10_6_29_patch1 with the updated configuration inline in the fragment. Assuming that the H7 version is the same or later as in 10_6_X, this is also needed in later versions.

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions [Didn't run tests. If tests were running Herwig showering, they'd have spotted the bug.]

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42019/35978

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @lmoureaux (Louis Moureaux) for master.

It involves the following packages:

• Configuration/Generator (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[menglu21]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb8b57/33263/summary.html
COMMIT: 5ce11f6
CMSSW: CMSSW_13_2_X_2023-06-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42019/33263/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3197958
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3197930
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[menglu21]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1