Initial GT Unpacker Inspector Prototype.

[aloeliger]

PR description:

Following the discovery of corrupted data out of the GT unpacker, the discussed intermediate solution is a filter that checks for corruption . This PR contains a prototype that checks a GT object output collection for having the correct number of BX's, and will fire the filter if this not found, and produce an empty vector for anything that might be caught by the filter (and pass through for anything else). I am calling this module/filter the GT Unpacker Inspector.

It is my understanding that the desired longer term solution may be a change in the way CMSSW handles skippable errors?

In theory, this is at least a partial solution to #41645

As of the writing of this, this is still a draft/prototype, and has not been hooked up to any of the original unpacker's clients. @mmusich @makortel Apologies for the long delay, but you were on the original thread where this solution was discussed, I wanted to tag you to understand if this is something that would meet the needs discussed there. If you have any review, I would appreciate this before I begin to start trying to insert this into the unpacking paths.

PR validation:

PR validation has not been possible due to the original file disappearing to tape, with the relvant block being 2.5 Tb (a little much to recall from tape for a single file). I would like to solicit suggestions for the testing of this module/technique.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport, but could be backported to reconstruction releases as necessary.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42005/35965

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42005/35965/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42005/35965/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42005/35966

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @aloeliger (Andrew Loeliger) for master.

It involves the following packages:

• EventFilter/L1TRawToDigi (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @Martin-Grunewald, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[aloeliger]

This has gone without update or comment for a while, (frankly I had forgotten I had opened this) I am assuming the need for this is no longer there or pressing. I am closing this PR

[mmusich]

@aloeliger can we at least test this before closing ? :)

[aloeliger]

@mmusich Sure, if you would like. I have honestly forgotten why I hadn't pushed this along further. I would need to reacquaint myself with this PR.

[aloeliger]

Reopened for testing

[mmusich]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63ab90/35394/summary.html
COMMIT: 5ae4a7b
CMSSW: CMSSW_13_3_X_2023-10-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42005/35394/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 22 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 1064
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356314
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[smuzaffar]

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

[antoniovilela]

ping (to make bot change milestone)

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.