Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.1.X] zeroed mono/stereo cluster counts in SiStripMonitorTrack at each event loop #41991

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 16, 2023

backport of #41989

PR description:

A trivial bug-fix follow-up PR to #41725.
The mono / stereo cluster counts introduced there need to be zeroed at each event loop, otherwise it will count all the hits in the run, leading to plots like this one:

Screenshot from 2023-06-16 18-00-33

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Intermediate verbatim backport of #41989

@mmusich
Copy link
Contributor Author

mmusich commented Jun 16, 2023

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 16, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_1_X.

It involves the following packages:

  • DQM/SiStripMonitorTrack (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 16, 2023

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Jun 17, 2023

@cmsbuild ping

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70eac1/33209/summary.html
COMMIT: 7207583
CMSSW: CMSSW_13_1_X_2023-06-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41991/33209/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221591
  • DQMHistoTests: Total failures: 178
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221391
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • dqm differences as expected from PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Jun 21, 2023

any reason to not merge this one?

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fd388b9 into cms-sw:CMSSW_13_1_X Jun 21, 2023
@mmusich mmusich deleted the zeroInClusterCounts_13_1_X branch June 22, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants