-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.1.X] zeroed mono/stereo cluster counts in SiStripMonitorTrack
at each event loop
#41991
[13.1.X] zeroed mono/stereo cluster counts in SiStripMonitorTrack
at each event loop
#41991
Conversation
type bug-fix |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_1_X. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
@cmsbuild ping |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70eac1/33209/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
any reason to not merge this one? |
+1 |
backport of #41989
PR description:
A trivial bug-fix follow-up PR to #41725.
The mono / stereo cluster counts introduced there need to be zeroed at each event loop, otherwise it will count all the hits in the run, leading to plots like this one:
PR validation:
cmssw
compilesIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Intermediate verbatim backport of #41989