Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nm dqm egamma v update for13 1 x #41987

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
129 commits
Select commit Hold shift + click to select a range
1d62793
Including new RPOTs 45-220-NR-HR and 56-220-NR-HR.
dfigueiredo Apr 10, 2023
2fa992f
fix code-checks
grzanka Apr 23, 2023
3994d40
correct max bins number
grzanka May 2, 2023
b944345
adjusted unit tests
grzanka May 3, 2023
0447b06
Merge pull request #41517 from mmusich/use_online_metadata_in_AlCaHOC…
cmsbuild May 5, 2023
57b97e5
Merge pull request #41556 from fwyzard/alpaka_llvm14_updates
cmsbuild May 5, 2023
8d7ac90
Backport of #41464 to CMSSW version 13_1_X which contains a bug fix f…
May 5, 2023
9056c64
Merge pull request #41555 from mmusich/improve_dyn_ineff_PI
cmsbuild May 5, 2023
d451253
move to Run3_2023 era in HLT-Validation and HLT-addon tests
missirol May 7, 2023
70b5d0e
adjusted RP naming
grzanka May 8, 2023
e44c420
HLT menu development for 13_0_X (branch: 13_1_X)
missirol May 9, 2023
0392acb
add frozen HLT pp menu "V1.1" of 2023
missirol May 9, 2023
36b790e
move HLT:@relval2023 to frozen HLT pp menu "V1.1" of 2023
missirol May 9, 2023
ac69812
Merge pull request #41545 from AlexDeMoor/from-CMSSW_13_1_0_pre2
cmsbuild May 9, 2023
f259152
Fix numeric issues in PFCand scaling, add some debug output
kdlong May 4, 2023
8330c44
Update run3 data GTs
francescobrivio May 10, 2023
0e42674
Merge pull request #41573 from missirol/devel_bxvectorSafeIsEmpty
cmsbuild May 10, 2023
940068d
Merge pull request #41576 from missirol/devel_hltPrescalerEmptyBX0Check
cmsbuild May 10, 2023
2d4ddab
Merge pull request #41563 from stahlleiton/from-CMSSW_13_1_0_pre4_isS…
cmsbuild May 10, 2023
d1008c9
Merge pull request #41520 from CTPPS/pps_NewRPOTsDIP_backport131
cmsbuild May 11, 2023
0b7b279
Merge pull request #41601 from cms-tsg-storm/HLTdevelopment130X_for131X
cmsbuild May 11, 2023
3a691bc
Oracle test: Use fake/random DB name
smuzaffar May 11, 2023
507fd50
Merge pull request #41569 from missirol/devel_triggerMonitorL1TLogError
cmsbuild May 11, 2023
92e646b
Merge pull request #41635 from smuzaffar/fix-oracle-test-13_1
cmsbuild May 12, 2023
59aec09
remove frozen 2022-v1.5 HLT menu
missirol Apr 27, 2023
539a54c
add 12434.7 wf (2023 ttbar mkFit) and improve customizeHLTIter0ToMkFit
missirol Apr 29, 2023
84a4d3c
use FakeHLT sequences for DQM and Validation in pre-2023 wfs
missirol Apr 29, 2023
cf1d4b0
Assign errors to right plots
fabferro May 12, 2023
dd0c3bd
Merge pull request #41610 from francescobrivio/alca-update_data_run3_…
cmsbuild May 12, 2023
11b03ba
extend x-axis range of "vs-lumi" harvesting outputs in HLT online-DQM
missirol May 14, 2023
cfbbed1
- intialize vectors before spawning threads to avoid waiting on a
smorovic May 14, 2023
a2d9782
DAQSource (same change as in FedRawDataInputSource)
smorovic May 14, 2023
cc1512b
put fake beamspot in the event if the arbitration returns a fake BS, …
mmusich Apr 24, 2023
9aeabd1
add a converter from BeamSpotObjects to BeamSpotOnlineObjects
mmusich May 6, 2023
f933305
add a method to copy parameters from BeamSpotObjects into BeamSpotOnl…
mmusich May 6, 2023
84271d4
use BeamSpotOnlineObjects::copyFromBeamSpotObject into BeamSpotOnline…
mmusich May 6, 2023
8848ad8
add BeamSpotOnlineFromOfflineConverter_cfg.py to package unit tests
mmusich May 7, 2023
d36e056
set the timeThreshold in hltOnlineBeamSpotESProducer_cfi in order to …
mmusich May 7, 2023
579d59f
supply BeamSpotOnlineObjects to the phase2_realistic autoCond key
mmusich May 6, 2023
6931514
Fix typo. Use Puppi version of ParticleNet in nanoAOD_addDeepInfoAK4 …
nurfikri89 May 15, 2023
36c2dc7
Fix typo in comment
nurfikri89 May 15, 2023
7339c2c
Merge pull request #41621 from rtschmitz/skimming_DelayedJetParking
cmsbuild May 15, 2023
774ffd8
Merge pull request #41666 from missirol/fix_hltOnlineDQMLumiRanges_131X
cmsbuild May 15, 2023
e6aede3
Merge pull request #41669 from smorovic/13_1_X-daqsource-race
cmsbuild May 15, 2023
52ee9b9
Merge pull request #41673 from mmusich/13_1_X_useFakeBSasFallBackInOn…
cmsbuild May 16, 2023
1e85fb0
fixes for 2016 data and mc
fabferro May 16, 2023
b488d2a
fixes
fabferro May 16, 2023
1f39d56
Merge pull request #41648 from cms-tsg-storm/remove2022HLTv1p5_131X
cmsbuild May 16, 2023
579a073
Merge pull request #41608 from kdlong/fixPFScaling_13_1
cmsbuild May 16, 2023
a34c667
Replaced AK4 and AK8 paths for particle net monitoring (2023)
May 16, 2023
2e70d4a
Merge pull request #41676 from mteroerd/adjustaxes_dqmpixel
cmsbuild May 17, 2023
132bebc
use qScale in charge reweighting
mroguljic Apr 25, 2023
4d89456
fix SiPixelCompareTrackSoA after portable data-format migration
mmusich May 18, 2023
0bd3703
Fix LumiCache in AlcaBeamMonitor
francescobrivio May 18, 2023
4db3ce3
Fix LumiCache in OnlineBeamMonitor
francescobrivio May 18, 2023
0afd55e
Add VertexSmearing scenario for 2023 MC
francescobrivio May 18, 2023
bd31dc4
Adding Number of RecHits plot for SiStrip stereo modules
mascioti May 18, 2023
40dca95
Fix code format
mascioti May 18, 2023
c13aace
Merge pull request #41530 from missirol/devel_fix41045_step2
cmsbuild May 19, 2023
0294399
Merge pull request #41729 from sunilUIET/addEraE_WFs
cmsbuild May 19, 2023
c3dc220
modernize TrackSplittingMonitor and bug-fix ME-s booking and filling
mmusich May 15, 2023
48d740e
add a fillDescriptions method to TrackSplittingMonitor and use it
mmusich May 15, 2023
1cf7fc6
remove cosmic track splitting from collisions tracking source
mmusich May 15, 2023
f638f0f
fix few axis labels
mmusich May 15, 2023
8f8abe8
Apply suggestions from code review
mmusich May 17, 2023
0043738
Merge pull request #41718 from mmusich/fixSiPixelCompareTrackSoA_post…
cmsbuild May 20, 2023
38172be
Merge pull request #41703 from marinakolosova/BPR_DQMPNet_131X
cmsbuild May 20, 2023
b6c9282
Merge pull request #41650 from fabferro/recoverDQMPlots_131x
cmsbuild May 20, 2023
efaaaba
Merge pull request #41708 from tvami/qScale_reweighting_131Backport
cmsbuild May 20, 2023
f6fc5c0
Merge pull request #41722 from francescobrivio/alca-alcaBeamMonitorFi…
cmsbuild May 20, 2023
ccbe252
Merge pull request #41558 from bsunanda/Run3-gex160Y
cmsbuild May 21, 2023
f90f373
Merge pull request #41720 from francescobrivio/alca-2023_MC_beamspot_…
cmsbuild May 21, 2023
5f439c1
Merge pull request #41732 from nurfikri89/portFrom132XTo131X_fixPNetP…
cmsbuild May 22, 2023
db4049f
fix bug in the BPix hits counting
mmusich May 24, 2023
5376c14
Merge pull request #41753 from mascioti/stereomodules131
cmsbuild May 24, 2023
cd34746
Merge pull request #41750 from jfernan2/fixDQMOnlineMode
cmsbuild May 25, 2023
92b074f
Merge pull request #41739 from mmusich/modernizeAndFixTrackSplittingM…
cmsbuild May 26, 2023
8aae116
migrate DiMuonMassBiasClient to create profiles
mmusich May 20, 2023
b7f2883
restrict the deltaEta for Z->mm events
mmusich May 22, 2023
e8c139d
leave the possibility to plot TH1s instead of TProfiles, off, by default
mmusich May 25, 2023
37ecc1b
improve labels for mean profiles
mmusich May 25, 2023
2fcc6f8
Merge pull request #41781 from mmusich/migrate_DiMuonMassBiasClient_t…
cmsbuild May 28, 2023
a16430c
TrackingMonitor: fix x-axis label in plots vs online luminosity
mmusich May 27, 2023
9638a10
improved file size/buffer size checks in DAQSource
smorovic May 30, 2023
76f53fa
FEDRawDataInputSource changes
smorovic May 30, 2023
79815fc
Online DQM configure timeThreshold appropriately when running in 'off…
mmusich May 30, 2023
91f135a
Fix logical error in mask flag check
abhih1 May 31, 2023
4a93e2d
Modify PU condition for MLDQM
abhih1 May 31, 2023
8ef3b40
Merge pull request #41817 from mmusich/fixLabelsInPlotsVsLumi_13_1_X
cmsbuild May 31, 2023
61f1998
Merge pull request #41824 from smorovic/13_1_X-inputsource-checks
cmsbuild Jun 1, 2023
a965868
Merge pull request #41822 from mmusich/timeThresholdOnlineDQM_13_1_X
cmsbuild Jun 1, 2023
7bf4737
Added support for new EMTF BDT pT scale for 2023
eyigitba May 28, 2023
b250034
Update ReweightUserHooks.h
menglu21 Jun 2, 2023
2650714
Update ReweightUserHooks.h
menglu21 Jun 2, 2023
f8eed85
Update muon (un)packer with support for fixed uGMT firwmare
dinyar Jun 1, 2023
f1597d9
Merge pull request #41850 from menglu21/CMSSW_13_1_X
cmsbuild Jun 2, 2023
97a64af
Merge pull request #41840 from eyigitba/EMTF_newBDTScale_May23_131X
cmsbuild Jun 4, 2023
231f2e7
Merge pull request #41831 from abhih1/Fixlogicalmask_131X
cmsbuild Jun 4, 2023
74ee9a1
HLT menu development for 13_0_X (branch: 13_1_X)
missirol Jun 4, 2023
14fd8c4
Move average calculations outside of jet constituents loop
nurfikri89 Jun 2, 2023
919d2b6
Merge pull request #41856 from dinyar/update-two-loose-muon-shower-un…
cmsbuild Jun 5, 2023
f8041c9
Merge pull request #41863 from cms-tsg-storm/HLTdevelopment130X_for131X
cmsbuild Jun 6, 2023
0f0f15b
add ME-s needed for per-LS certification of Tracking at HLT in nanoDQ…
mmusich Jun 2, 2023
440c039
Remove stripTrackerHVOn check for BeamSpotLegacy client
francescobrivio Jun 5, 2023
9d7e691
Merge pull request #41869 from nurfikri89/portFrom132XTo131X_puIdFix_…
cmsbuild Jun 6, 2023
cd92dac
add L1nano customise if NANO is requested
vlimant Jun 5, 2023
93cfcc5
Merge pull request #41882 from francescobrivio/alca-update_BS_trk_HV_…
cmsbuild Jun 7, 2023
61ca664
Merge pull request #41878 from mmusich/addMEsForTrackingHLTMonitoring…
cmsbuild Jun 7, 2023
c2dd0c3
Merge pull request #41889 from perrotta/L1NANOinPromptReco_13_1_X
cmsbuild Jun 8, 2023
5bbaeac
Utilities/StaticAnalyzers: Remove postprocess-scan-build.py script no…
gartung Jun 8, 2023
5d0812e
Merge pull request #41904 from gartung/gartung-SA-remove-post-process…
cmsbuild Jun 9, 2023
56f0b64
Fix a race condition in StMeasurementDetSet
makortel Jun 5, 2023
312ba75
No need to encode to UTF-8 in python3 since strings are unicode by de…
amecca Jun 1, 2023
67fd0a5
Merge pull request #41911 from mmusich/AllInOne_ZmumuFixes_13_1_X
cmsbuild Jun 9, 2023
f590b17
Merge pull request #41909 from makortel/stMeasurementDetSetThreadSafe…
cmsbuild Jun 12, 2023
8512d34
Add isAvailable() function to RefToBaseProd
makortel Jun 2, 2023
25cd6c8
Add a comment the isAvailable() function is potentially costly
makortel Jun 9, 2023
3ca1052
Merge pull request #41931 from makortel/refToBaseProdIsAvailable_131x
cmsbuild Jun 13, 2023
bec539c
add SimBeamSpotObjects to standard payload utilities
francescobrivio Jun 10, 2023
daf6dd0
add cfg writer for SimBeamSpotObjects payloads
francescobrivio Jun 10, 2023
4a4f8bd
add setters and getters in CondFormats SimBeamSpotObjects
francescobrivio Jun 11, 2023
7ddd3f8
add Payload Inspector for SimBeamSpotObjects
francescobrivio Jun 11, 2023
68fbaac
Move SimBeamSpotObject producers to CondTools/BeamSpot
francescobrivio Jun 11, 2023
ad63263
armonize SimBeamSpotObjects units
francescobrivio Jun 11, 2023
03af6ab
add SimBeamSpotObjects reader and use cfi files
francescobrivio Jun 11, 2023
78ee4e1
apply cms naming rules and alpha-order imports
francescobrivio Jun 12, 2023
efca3b9
add unittest for simBeamSpot writer and reader
francescobrivio Jun 12, 2023
83835cb
Merge pull request #41940 from francescobrivio/alca-simBS_13_1_X
cmsbuild Jun 13, 2023
2799bf4
Split the dR plot for neutral hadrons in two eta ranges in the EB (ma…
nancymarinelli Jun 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions Alignment/OfflineValidation/bin/Zmumumerge.cc
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ const TString tstring_variables_name[variables_number] = {
void Fitting_GetMassmeanVSvariables(TString inputfile_name, TString output_path) {
TH2D* th2d_mass_variables[variables_number];
TFile* inputfile = TFile::Open(inputfile_name.Data());
TDirectoryFile* tdirectory = (TDirectoryFile*)inputfile->Get("myanalysis");
TDirectoryFile* tdirectory = (TDirectoryFile*)inputfile->Get("DiMuonMassValidation");
for (int i = 0; i < variables_number; i++) {
TString th2d_name = Form("th2d_mass_%s", tstring_variables_name[i].Data());
th2d_mass_variables[i] = (TH2D*)tdirectory->Get(th2d_name);
Expand Down Expand Up @@ -238,12 +238,18 @@ void Draw_TH1D_forMultiRootFiles(const vector<TString>& file_names,
}
lg->Draw("same");
c->SaveAs(output_name);
if (output_name.Contains(".pdf")) {
TString output_name_png(output_name); // output_name is const, copy to modify
output_name_png.Replace(output_name_png.Index(".pdf"), 4, ".png");
c->SaveAs(output_name_png);
}
}

int Zmumumerge(int argc, char* argv[]) {
vector<TString> vec_single_file_path;
vector<TString> vec_single_file_name;
vector<TString> vec_global_tag;
vector<TString> vec_title;
vector<int> vec_color;
vector<int> vec_style;

Expand All @@ -260,6 +266,7 @@ int Zmumumerge(int argc, char* argv[]) {
vec_color.push_back(childTree.second.get<int>("color"));
vec_style.push_back(childTree.second.get<int>("style"));
vec_global_tag.push_back(childTree.second.get<std::string>("globaltag"));
vec_title.push_back(childTree.second.get<std::string>("title"));

//Fitting_GetMassmeanVSvariables(childTree.second.get<std::string>("file") + "/Zmumu.root", childTree.second.get<std::string>("file"));
}
Expand All @@ -278,15 +285,15 @@ int Zmumumerge(int argc, char* argv[]) {
TString th1d_name = Form("th1d_meanmass_%s", tstring_variables_name[idx_variable].Data());
Draw_TH1D_forMultiRootFiles(
vec_single_fittingoutput,
vec_global_tag,
vec_title,
vec_color,
vec_style,
th1d_name,
merge_output + Form("/meanmass_%s_GTs.pdf", tstring_variables_name[idx_variable].Data()));
TString th1d_name_entries = Form("th1d_entries_%s", tstring_variables_name[idx_variable].Data());
Draw_TH1D_forMultiRootFiles(
vec_single_fittingoutput,
vec_global_tag,
vec_title,
vec_color,
vec_style,
th1d_name_entries,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import math
import json
import os
from sys import version_info

import FWCore.ParameterSet.Config as cms
import FWCore.PythonUtilities.LumiList as LumiList
Expand All @@ -26,7 +27,10 @@
# Read in AllInOne config in JSON format
###################################################################
with open(options.config, "r") as configFile:
config = _byteify(json.load(configFile, object_hook=_byteify),ignore_dicts=True)
if version_info.major == 2:
config = _byteify(json.load(configFile, object_hook=_byteify),ignore_dicts=True)
else:
config = json.load(configFile)

###################################################################
# Read filenames from given TXT file
Expand Down
16 changes: 12 additions & 4 deletions Calibration/HcalAlCaRecoProducers/plugins/AlCaHOCalibProducer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ Ring 0 L0 : Width Tray 6:266.6, 5&4:325.6, 3:330.6, 2:341.6, 1:272.6
#include "DataFormats/HcalRecHit/interface/HcalRecHitCollections.h"
#include "DataFormats/GeometrySurface/interface/PlaneBuilder.h"
#include "DataFormats/Luminosity/interface/LumiDetails.h"
#include "DataFormats/OnlineMetaData/interface/OnlineLuminosityRecord.h"
#include "DataFormats/Math/interface/Error.h"
#include "DataFormats/MuonReco/interface/Muon.h"
#include "DataFormats/RecoCandidate/interface/IsoDeposit.h"
Expand Down Expand Up @@ -199,6 +200,7 @@ class AlCaHOCalibProducer : public edm::one::EDProducer<edm::one::SharedResource
edm::EDGetTokenT<reco::VertexCollection> tok_vertex_;
// edm::EDGetTokenT<LumiDetails> tok_lumi_;
edm::EDGetTokenT<LumiScalersCollection> tok_lumi_;
edm::EDGetTokenT<OnlineLuminosityRecord> tok_metaData_;

edm::EDGetTokenT<HBHERecHitCollection> tok_hbhe_;
edm::EDGetTokenT<HORecHitCollection> tok_ho_;
Expand Down Expand Up @@ -257,6 +259,7 @@ AlCaHOCalibProducer::AlCaHOCalibProducer(const edm::ParameterSet& iConfig) {
tok_vertex_ = consumes<reco::VertexCollection>(iConfig.getParameter<edm::InputTag>("vertexTags"));
// tok_lumi_ = consumes<LumiDetails ,edm::InLumi>(iConfig.getParameter<edm::InputTag>("lumiTags"));
tok_lumi_ = consumes<LumiScalersCollection>(iConfig.getParameter<edm::InputTag>("lumiTags"));
tok_metaData_ = consumes<OnlineLuminosityRecord>(iConfig.getParameter<edm::InputTag>("metadata"));
tok_ho_ = consumes<HORecHitCollection>(iConfig.getParameter<edm::InputTag>("hoInput"));
tok_hbhe_ = consumes<HBHERecHitCollection>(iConfig.getParameter<edm::InputTag>("hbheInput"));
tok_tower_ = consumes<CaloTowerCollection>(iConfig.getParameter<edm::InputTag>("towerInput"));
Expand Down Expand Up @@ -301,6 +304,7 @@ void AlCaHOCalibProducer::fillDescriptions(edm::ConfigurationDescriptions& descr
desc.addUntracked<edm::InputTag>("muons", edm::InputTag("muons"));
desc.add<edm::InputTag>("vertexTags", edm::InputTag("offlinePrimaryVertices"));
desc.add<edm::InputTag>("lumiTags", edm::InputTag("scalersRawToDigi"));
desc.add<edm::InputTag>("metadata", edm::InputTag("onlineMetaDataDigis"));
descriptions.add("alcaHOCalibProducer", desc);
}

Expand Down Expand Up @@ -343,13 +347,17 @@ void AlCaHOCalibProducer::produce(edm::Event& iEvent, const edm::EventSetup& iSe
tmpHOCalib.inslumi = 0.;

auto const& lumiScale = iEvent.getHandle(tok_lumi_);
auto const& metaData = iEvent.getHandle(tok_metaData_);

if (lumiScale.isValid()) {
if (lumiScale->empty()) {
edm::LogError("HOCalib") << "lumiScale collection is empty";
} else {
// by default use Run-3 access (onlineMetaDataDigis)
if (metaData.isValid()) {
tmpHOCalib.inslumi = metaData->avgPileUp();
} else if (lumiScale.isValid() && !lumiScale->empty()) {
if (lumiScale->begin() != lumiScale->end()) {
tmpHOCalib.inslumi = lumiScale->begin()->pileup();
}
} else {
edm::LogWarning("HOCalib") << "Neither LumiScalers nor OnlineMetadata collections found in the event";
}
}
}
Expand Down
1 change: 1 addition & 0 deletions Calibration/HcalAlCaRecoProducers/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<use name="DataFormats/HcalRecHit"/>
<use name="DataFormats/JetReco"/>
<use name="DataFormats/Luminosity"/>
<use name="DataFormats/OnlineMetaData"/>
<use name="DataFormats/METReco"/>
<use name="DataFormats/RecoCandidate"/>
<use name="DataFormats/Scalers"/>
Expand Down
Loading