Phase2-hgx341B Try to provide the dd4hep version of the plugins for passive components of V18 Silicon modules of HGCal

[bsunanda]

PR description:

Try to provide the dd4hep version of the plugins for passive components of V18 Silicon modules of HGCal

PR validation:

Pending test using the dumpHGCalPassive in Geometry/HGCalCommonData/test/python

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41983/35948

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41983/35948/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41983/35948/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41983/35949

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[ianna]

@bsunanda - from a quick scan I do not see anything wrong with the algorithm. What is the error you get? Thanks!

[bsunanda]

@ianna When I run the test code (../src/Geometry/HGCalCommonData/test/python/dumpHGCalPassive_cfg.py type=DD4hep), I get at the end the following message:
DDHGCalPassivePartial: Creating an instance
DDHGCalPassivePartial: Module hgcalPassive:HGCalEEPartialAbsorber1 made of mater
ials:Air T 3.67 Wafer 2r 167.441 Half Separation 0
DD4CMS ERROR +++ Attempt to access non-existing algorithm option hgcal
:DDHGCalPassivePartial[{lacementIndex]
DD4CMS ERROR Exception while processing xml source:file:///build/sunanda/CMSSW_13_2_X_2023-06-15-2300/src/Geometry/HGCalCommonData/data/hgcalPassive/v18/hgcalPassive.xml
DD4CMS ERROR ----> DD4CMS: +++ Attempt to access non-existing algorithm option hgcal:DDHGCalPassivePartial[{lacementIndex]
dd4hep: Error interpreting XML nodes of type
dd4hep: Error interpreting XML nodes of type
----- Begin Fatal Exception 16-Jun-2023 03:52:09 CEST-----------------------
An exception of category 'StdException' occurred while
[0] Processing Event run: 1 lumi: 1 event: 1 stream: 0
[1] Running path 'p'
[2] Prefetching for module DDTestDumpFile/'dump'
[3] Calling method for EventSetup module DDDetectorESProducer/''
Exception Message:
A std::exception was thrown.
DD4CMS: +++ Attempt to access non-existing algorithm option hgcal:DDHGCalPassivePartial[{lacementIndex]

It does all required steps for the algorithm hgcal:DDHGCalPassiveFull

[ianna]

@bsunanda - I think, it's just a typo.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41983/35979

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #41983 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a68994/33250/summary.html
COMMIT: aa83b87
CMSSW: CMSSW_13_2_X_2023-06-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41983/33250/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 14 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3196062
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3196032
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1