-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change EMTF Primitive Conversion LUT Assignment for MC #41954
Conversation
test parameters:
|
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41954/35924
|
A new Pull Request was created by @eyigitba for master. It involves the following packages:
@epalencia, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
urgent
|
+l1
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9a82b/33140/summary.html Comparison SummarySummary:
|
+1 |
PR description:
This PR makes the primitive conversion LUT loading for MC inclusive for
pc_lut_version
. In data, based on muon detector alignment we use a different version of PC LUT, but in MC we always use ideal aligment. This PR fixes this assignment for MC for all future PC LUTs.This will be backported to 13_1_X and 13_0_X.
PR validation:
Tested with
addOnTests.py
and the new GT131X_mcRun3_2023_realistic_v6
. Workflow crashes without this PR, doesn't crash with the PR included.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
FYI: @francescobrivio