Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EMTF Primitive Conversion LUT Assignment for MC #41954

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

eyigitba
Copy link
Contributor

@eyigitba eyigitba commented Jun 14, 2023

PR description:

This PR makes the primitive conversion LUT loading for MC inclusive for pc_lut_version. In data, based on muon detector alignment we use a different version of PC LUT, but in MC we always use ideal aligment. This PR fixes this assignment for MC for all future PC LUTs.

This will be backported to 13_1_X and 13_0_X.

PR validation:

Tested with addOnTests.py and the new GT 131X_mcRun3_2023_realistic_v6. Workflow crashes without this PR, doesn't crash with the PR included.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

FYI: @francescobrivio

@francescobrivio
Copy link
Contributor

test parameters:

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41954/35924

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @eyigitba for master.

It involves the following packages:

  • L1Trigger/L1TMuonEndCap (l1)

@epalencia, @aloeliger can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @JanFSchulte, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor

urgent

@aloeliger
Copy link
Contributor

+l1

  • Changes are minimal, no issues as long as the tests come back okay.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9a82b/33140/summary.html
COMMIT: 00f01f2
CMSSW: CMSSW_13_2_X_2023-06-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41954/33140/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 109 lines to the logs
  • Reco comparison results: 5458 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196062
  • DQMHistoTests: Total failures: 119637
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3076403
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.328 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): -0.164 KiB L1T/L1TStage2uGT
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 46 workflows

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants